restrict xpath string-to-number conversion to the number grammar#286
Open
rootvector2 wants to merge 1 commit into
Open
restrict xpath string-to-number conversion to the number grammar#286rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
Double.parseDouble/Double.valueOf in InfoSetUtil.doubleValue and number accept Java literals (leading +, exponents, d/f suffixes, hex, Infinity/NaN) that the XPath 1.0 number grammar excludes and which XPath requires to be NaN; gate both on the Number production so e.g. number('1e3') is NaN instead of 1000.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mvn; that'smvnon the command line by itself.InfoSetUtil.doubleValueandInfoSetUtil.numbercoerce string values to numbers withDouble.parseDouble/Double.valueOf, which accept Java number literals the XPath 1.0 number grammar does not: a leading+, exponents like1e3,d/ftype suffixes like5d, hexadecimal floats, and theInfinity/NaNwords. XPath requires every such string to becomeNaN, so todaynumber('1e3')is1000,'5d' >= 5is true, and'1e3' = 1000is true. Spotted while checkingnumber()against the spec; the existingfloor('NaN')cases only pass becauseDouble.parseDoublehappens to acceptNaN.Both methods now gate the conversion on a
Patternfor theNumberproduction (optional whitespace and minus around digits with an optional fraction) and returnNaNotherwise. The check lives inInfoSetUtilbecausenumber(), the relational operators andfloor/ceiling/roundall coerce through these two methods, so node models and callers stay untouched.floor('NaN')and friends keep returningNaNsince the word is rejected the same way.