fix lang() to match whole language subtags, not any prefix#287
Open
rootvector2 wants to merge 1 commit into
Open
fix lang() to match whole language subtags, not any prefix#287rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
isLanguage matched with String.startsWith, so lang('f') matched xml:lang="fr" and lang('e') matched an en-US locale; XPath 1.0 section 4.3 requires the argument to equal the tag or a subtag delimited by '-'. Apply that rule in one NodePointer helper shared by the DOM and JDOM overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Commons!
mvn; that'smvnon the command line by itself.NodePointer.isLanguageand itsDOMNodePointer/JDOMNodePointeroverrides test the language withString.startsWith, solang()matches any leading character prefix of the node'sxml:lang(or the locale name) instead of a whole subtag. I noticed it reading thelang()predicate path: a node withxml:lang="fr"satisfieslang('f'), and a locale ofen-USsatisfieslang('e')andlang('en-'), all of which must be false per XPath 1.0 section 4.3, which matches only when the argument equals the tag or a subtag delimited by-. Sincelang()is used in predicates to select nodes, the over-match changes which nodes a filter returns for caller-suppliedxml:langdata. The fix requires an exact case-insensitive match or alang-prefix, in one shared helper used by all three implementations. The added assertions fail on the current code (lang('f')andlang('e')return true) and pass with the change.