Skip to content

Bump org.apache.maven.plugins:maven-source-plugin from 3.2.1 to 3.4.0.#704

Merged
garydgregory merged 1 commit intoapache:masterfrom
slawekjaranowski:bump-maven-source-plugin-3.4.0
Apr 27, 2026
Merged

Bump org.apache.maven.plugins:maven-source-plugin from 3.2.1 to 3.4.0.#704
garydgregory merged 1 commit intoapache:masterfrom
slawekjaranowski:bump-maven-source-plugin-3.4.0

Conversation

@slawekjaranowski
Copy link
Copy Markdown
Member

What changed:

  • Updated version.maven-source-plugin from 3.2.1 to 3.4.0.

  • Use the same name for execution as is in parent to allow add next goal to existing execution without trigger the same build twice

  • Removed plugin execution from apache-release profile - it will trigger second build of the same artifact

This resolves a problem reported in issue:


I have tested on commons-validator with profiles release - commons custom and apache-release from ASF parent


Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

What changed:
- Updated `version.maven-source-plugin` from 3.2.1 to 3.4.0.

- Use the same name for execution as is in parent to allow add next goal to existing execution without trigger the same build twice

- Removed plugin execution from apache-release profile - it will trigger second build of the same artifact

This resolves a problem reported in issue:
- apache/maven-source-plugin#205
@garydgregory
Copy link
Copy Markdown
Member

@slawekjaranowski
Copy link
Copy Markdown
Member Author

-1 until https://issues.apache.org/jira/projects/MSOURCES/issues/MSOURCES-143 is fixed.

My test show, that was resolved in:

testing with JDK 1.8, I see:

INFO] --- source:3.4.0:jar-no-fork (attach-sources) @ commons-validator ---
[INFO] Artifact commons-validator:commons-validator:java-source:sources:1.10.2-SNAPSHOT already attached to target/commons-validator-1.10.2-SNAPSHOT-sources.jar: ignoring same re-attach (same artifact, same file)
[INFO] 
[INFO] --- source:3.4.0:test-jar-no-fork (attach-sources) @ commons-validator ---
[INFO] Artifact commons-validator:commons-validator:java-source:test-sources:1.10.2-SNAPSHOT already attached to target/commons-validator-1.10.2-SNAPSHOT-test-sources.jar: ignoring same re-attach (same artifact, same file)

@garydgregory
Copy link
Copy Markdown
Member

Thank you @slawekjaranowski , I'll test in a few projects tomorrow AM.

@garydgregory garydgregory merged commit 146d8a8 into apache:master Apr 27, 2026
9 checks passed
@garydgregory
Copy link
Copy Markdown
Member

I tested this patch with a local installation and the following:

  • Commons CLI
  • Commons Digester
  • Commons Collections
  • Commons Logging

@slawekjaranowski slawekjaranowski deleted the bump-maven-source-plugin-3.4.0 branch April 27, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants