chore: record per-query timings for multi-statement TPC files#4271
Draft
andygrove wants to merge 1 commit intoapache:mainfrom
Draft
chore: record per-query timings for multi-statement TPC files#4271andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
Some TPC-DS files (q14, q23, q24, q39) contain two SELECT statements that were previously timed as a single unit. TPC-H q15 wraps a SELECT in CREATE / DROP VIEW statements that should keep executing but should not be treated as separate queries. Classify each `;`-split statement as SELECT/WITH (timed) or DDL (executed only). Multi-SELECT files record per-query timings under keys like `14a` and `14b`; single-SELECT files keep their existing key. As a side effect, q15's row_count and result_hash now come from the SELECT rather than the trailing DROP VIEW. generate-comparison.py is updated to accept alphanumeric query keys and sort them so `14`, `14a`, `14b`, `15` appear in natural order; otherwise the new sub-query timings would be silently filtered out of comparison charts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Some TPC-DS files (q14, q23, q24, q39) contain two SELECT statements that were previously timed as a single unit. TPC-H q15 wraps a SELECT in CREATE / DROP VIEW statements that should keep executing but should not be treated as separate queries.
Classify each
;-split statement as SELECT/WITH (timed) or DDL (executed only). Multi-SELECT files record per-query timings under keys like14aand14b; single-SELECT files keep their existing key. As a side effect, q15's row_count and result_hash now come from the SELECT rather than the trailing DROP VIEW.generate-comparison.py is updated to accept alphanumeric query keys and sort them so
14,14a,14b,15appear in natural order; otherwise the new sub-query timings would be silently filtered out of comparison charts.What changes are included in this PR?
How are these changes tested?