CI: Add workflow to verify release candidate on multiple systems#4275
CI: Add workflow to verify release candidate on multiple systems#4275kevinjqliu wants to merge 9 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
| # Skip spotless since the source was already checked before release. | ||
| # Spotless can fail on Windows due to CRLF line ending differences. | ||
| ./mvnw verify -Prelease -DskipTests -P"spark-3.4" -Dmaven.gitcommitid.skip=true -Dspotless.check.skip=true |
There was a problem hiding this comment.
adds -Dspotless.check.skip=true here. The Spotless formatting plugin is failing due to line ending differences (LF in the tarball vs CRLF expected on Windows).
See https://github.com/kevinjqliu/datafusion-comet/actions/runs/25614322434/job/75189622764
| set -e | ||
| pushd native | ||
| RUSTFLAGS="-Ctarget-cpu=native" cargo build --release | ||
| cargo build --release ${COMET_CARGO_BUILD_ARGS:-} |
There was a problem hiding this comment.
RUSTFLAGS not needed here, removing it so that it can be overriden by env var in verify-release-candidate.yml
|
we can also add this workflow to the release instructions, similar to in datafusion-python https://github.com/apache/datafusion-python/pull/1388/files#diff-7b90af0d72004d8b923b4ed55f67a5f3e40e6a08ec9637f382d6506dd309848dR157-R174 |
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
2 participants
Which issue does this PR close?
Closes #.
Rationale for this change
This PR adds a manually triggered GitHub Actions workflow to verify release candidates across multiple OS/architecture combinations
Copied over from datafusion-python, https://github.com/kevinjqliu/datafusion-python/blob/baf4a7a47fc30cdb759ef7b7f9e5df6c38db8a57/.github/workflows/verify-release-candidate.yml
What changes are included in this PR?
How are these changes tested?
Ran manually on my fork, https://github.com/kevinjqliu/datafusion-comet/actions/runs/25614322434