perf: optimize spark_log in datafusion-comet-spark-expr#4896
Draft
andygrove wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — autonomous exploratory PR.
Rationale for this change
Hoist the constant operand's ln() out of the per-element loop in the scalar-base and scalar-value paths, removing one transcendental ln() call per row while preserving exact null/NaN semantics.
What changes are included in this PR?
Hoist the constant operand's ln() out of the per-element loop in the scalar-base and scalar-value paths, removing one transcendental ln() call per row while preserving exact null/NaN semantics.
How are these changes tested?
Correctness: unit tests + seeded differential fuzz (bit-identical Arrow output vs
main).Benchmark (criterion):