-
Notifications
You must be signed in to change notification settings - Fork 379
feat: support bloom filters in native Iceberg writes #5724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NikitaMatskevich
wants to merge
12
commits into
apache:main
Choose a base branch
from
NikitaMatskevich:feat/iceberg-bloom-filter-writes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d60c19f
feat: support bloom filters in native Iceberg writes
NikitaMatskevich b544d41
feat: support Iceberg bloom filter write settings
NikitaMatskevich b185224
fix: fall back for sanitized Iceberg bloom paths
NikitaMatskevich 4a5ec47
test: gate Iceberg bloom shape properties independently
NikitaMatskevich fcef2c4
fix: match Iceberg-version bloom property support
NikitaMatskevich 709a360
fix: use Parquet 59 bloom filter APIs
NikitaMatskevich 298cdc7
fix: satisfy formatting checks
NikitaMatskevich 050e3a0
docs: describe Parquet 59 bloom folding
NikitaMatskevich 3a09810
fix: reject zero bloom filter FPP
NikitaMatskevich 15333e7
fix: ignore unused bloom max byte caps
NikitaMatskevich 79145dc
test: document bloom folding after writes
NikitaMatskevich 6cdd0a7
test: lock bloom sizing parity across runtimes
NikitaMatskevich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed opt-in for native Bloom writes sounds reasonable. Could this paragraph explicitly say that folding trades smaller files for potentially higher realised FPP and less pruning than Java? A table-level NDV estimate can exceed a row group's actual NDV because of skew or a small final row group, so this does not require a badly configured table.
When documenting the new option, please also make clear that disabling it selects the JVM writer for Bloom-enabled tables; it cannot disable folding within parquet-rs yet.