Skip to content

test: fix flaky mixed field id directory test on Spark 3.4 and 3.5 #6312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 1 commit into from
Sep 28, 2026
Merged

test: fix flaky mixed field id directory test on Spark 3.4 and 3.5 #6312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2427,7 +2427,10 @@ abstract class ParquetReadSuite extends CometTestBase {

// Spark checks each file on its own. A directory holding one file with ids and one without
// raises on the second, and with `ignoreMissing` the file without ids reads as nulls because
// no root field of it carries the requested id.
// no root field of it carries the requested id. Each side is written as one file. Spread over
// the session's cores, each write would also leave an empty `part-00000`, and on Spark 3.x a
// file without ids read after an empty one in the same task raises inside one more
// `SparkException`, so the error the job reports would depend on which task failed first.
test("a file without ids next to a file with ids is checked on its own") {
withSQLConf(SQLConf.PARQUET_FIELD_ID_READ_ENABLED.key -> "true") {
withTempPath { dir =>
Expand All @@ -2436,11 +2439,13 @@ abstract class ParquetReadSuite extends CometTestBase {
val readSchema = new StructType().add("a", IntegerType, true, withId(1))
spark
.createDataFrame(spark.sparkContext.parallelize(Seq(Row(100), Row(200))), idSchema)
.repartition(1)
.write
.mode("overwrite")
.parquet(dir.getCanonicalPath)
spark
.createDataFrame(spark.sparkContext.parallelize(Seq(Row(1), Row(2))), plainSchema)
.repartition(1)
.write
.mode("append")
.parquet(dir.getCanonicalPath)
Expand Down
Loading