Refactor: replace dialect_of! table partition check with Dialect trait method - #2526
Open
jerguslejko wants to merge 1 commit into
Open
jerguslejko wants to merge 1 commit into
jerguslejko wants to merge 1 commit into
Conversation
jerguslejko
marked this pull request as ready for review
September 18, 2026 08:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the work from #2171 and #2175 by replacing one more
dialect_of!macro usage with aDialecttrait method, so user-defined dialects can opt into table-factorPARTITIONparsing.New trait method:
supports_table_partitionsPARTITION (p0, p1)on a table factorAlso implemented for
GenericDialect(returningtrue), matching the dialects the previousdialect_of!(self is MySqlDialect | GenericDialect)check named. The default isfalse, so behaviour is unchanged for every existing dialect.Motivation is the one described in #1430 and #1186: a custom dialect wrapping
PostgreSqlDialectcannot reach this branch at all today, becausedialect_of!is aTypeIdcheck that only matches built-in dialects.Test plan
parse_table_partition_selectiontests/sqlparser_custom_dialect.rs: a custom dialect opting in parses and round-tripsSELECT * FROM employees PARTITION (p0, p1); one that does not opt in still rejects itcargo clippy --all-targets --all-features -- -D warningspassescargo fmt --all -- --checkpasses