Skip to content

Deny clippy::dbg_macro and clippy::todo - #2654

Merged
alamb merged 1 commit into
mainfrom
deny-dbg-macro-todo
Oct 18, 2026
Merged

alamb merged 1 commit into
mainfrom
deny-dbg-macro-todo

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

Denies clippy::dbg_macro and clippy::todo so debugging output and unfinished stubs cannot land. This removes the one leftover dbg! in a span test, and there is no todo! today.

@github-actions

Copy link
Copy Markdown

No dialect label was applied because the title does not name a SQL dialect.

If this change targets one or more dialects, edit the title to <Dialect>[, <Dialect>]: <description>, add a Dialects: <Dialect>[, <Dialect>] line to the description, or reply with one. Reply Dialects: none if the change is dialect-agnostic.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.24%. Comparing base (7b5821d) to head (fa041dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
- Coverage   81.24%   81.24%   -0.01%     
==========================================
  Files          42       42              
  Lines       33901    33900       -1     
  Branches    33901    33900       -1     
==========================================
- Hits        27543    27542       -1     
  Misses       2792     2792              
  Partials     3566     3566              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 added enhancement New feature or request waiting on reviewer PR needs to be reviewed labels Oct 17, 2026

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alamb
alamb added this pull request to the merge queue Oct 18, 2026
Merged via the queue into main with commit 8977e96 Oct 18, 2026
14 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the deny-dbg-macro-todo branch October 18, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request waiting on reviewer PR needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants