Update sqlite recursion limit expectations for limit 51 (sqlparser upgrade) - #23
Merged
Merged
Conversation
DataFusion is upgrading to sqlparser 0.63.0, which adds recursion guards to more parse functions so every expression consumes one more level of the parser recursion budget. To keep previously-parseable queries working, DataFusion is raising the default `datafusion.sql_parser.recursion_limit` from 50 to 51 (apache/datafusion#25278). Update the 275 `RecursionLimitExceeded` expectations across 15 sqlite test files to expect `(current limit: 51)`. The queries still fail with the new limit, only the limit reported in the error message changes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
alamb
changed the title
viirya
approved these changes
Sep 17, 2026
alamb
commented
Sep 17, 2026
| # Datafusion - Datafusion expected results: | ||
| # Datafusion - Expected - 0 | ||
| query error DataFusion error: SQL error: RecursionLimitExceeded \(current limit: 50\) | ||
| query error DataFusion error: SQL error: RecursionLimitExceeded \(current limit: 51\) |
Contributor
Author
There was a problem hiding this comment.
just the message changes, everything else is the same
Contributor
Author
|
Thank you @viirya |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
In apache/datafusion#25278, I am upgrading
sqlparserto 0.63.0, which adds recursion guards to more parse functions (e.g. data type andINTERVALparsing).This means that some queries no longer pass under the old cap of 50, so I changed the default recursion limit to 51 to avoid rejecting queries that previously parsed successfully. However, a bunch of tests embed that constant in the expected results, so I need to change this repo too
Changes
Update 275
RecursionLimitExceedederror-message expectationsTesting
Pointed DataFusion's
datafusion-testingsubmodule at this commit, with apache/datafusion#25278 plus the default set to 51, and ran:All 1,115 files completed successfully.