Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ datafusion-session = { path = "datafusion/session", version = "54.0.0" }
datafusion-spark = { path = "datafusion/spark", version = "54.0.0" }
datafusion-sql = { path = "datafusion/sql", version = "54.0.0" }
datafusion-substrait = { path = "datafusion/substrait", version = "54.0.0" }
genawaiter = { version = "0.99.1", default-features = false }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed some reluctance in other PRs to pull in additional dependencies since the dependency graph is quite large already. Not sure what the policy is to accept or reject new ones.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good thing is that this does not have any dependencies at all

  • no runtime dependencies
    • no compile-time dependencies either, with default-features = false

From genawaiter README

https://github.com/whatisaphone/genawaiter/blob/45c10c223b92da215e182bc3eff0d5e09bf813f4/Cargo.toml#L17-L21

The only dependencies that we are using with the enabled futures feature already exists


doc-comment = "0.3"
env_logger = "0.11"
Expand Down
1 change: 1 addition & 0 deletions datafusion/physical-plan/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ datafusion-physical-expr-common = { workspace = true }
datafusion-proto-common = { workspace = true, optional = true }
datafusion-proto-models = { workspace = true, optional = true }
futures = { workspace = true }
genawaiter = { workspace = true, features = ["futures03"] }
half = { workspace = true }
hashbrown = { workspace = true }
indexmap = { workspace = true }
Expand Down
4 changes: 3 additions & 1 deletion datafusion/physical-plan/src/sorts/cursor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
// under the License.

use std::cmp::Ordering;
use std::fmt::Debug;
use std::sync::Arc;

use arrow::array::{
Expand All @@ -32,7 +33,7 @@ use datafusion_execution::memory_pool::MemoryReservation;
///
/// This is a trait as there are several specialized implementations, such as for
/// single columns or for normalized multi column keys ([`Rows`])
pub trait CursorValues {
pub trait CursorValues: Debug + Sync + Send {
fn len(&self) -> usize;

/// Returns true if `l[l_idx] == r[r_idx]`
Expand Down Expand Up @@ -302,6 +303,7 @@ impl<T: ArrowNativeTypeOp> CursorValues for PrimitiveValues<T> {
}
}

#[derive(Debug)]
pub struct ByteArrayValues<T: OffsetSizeTrait> {
offsets: OffsetBuffer<T>,
values: Buffer,
Expand Down
Loading
Loading