-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Simplifying SortPreservingMergeStream to use generators instead of state machine
#23407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rluvaton
wants to merge
21
commits into
apache:main
Choose a base branch
from
rluvaton:use-yield
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4e64c65
use yield
rluvaton 4432b46
prototype
rluvaton 81f6c59
Merge branch 'main' into use-yield
rluvaton 079fc8a
fix compilation
rluvaton 18262df
try another way with different crate
rluvaton d01f841
fix - emit all and not wait before emitting next
rluvaton ffd603e
c
rluvaton e6df5f5
add comment
rluvaton 847172e
add metrics support for adapter
rluvaton 0adc2e5
align with main
rluvaton f438d7b
use observed stream
rluvaton fa51b4f
Merge branch 'main' into use-yield
rluvaton 6171c12
uncomment pr
rluvaton e56c139
add into stream
rluvaton 72f3513
format
rluvaton 03441d0
revert test to main
rluvaton 3e5ab00
fix test
rluvaton 9251ed5
Merge branch 'main' into use-yield
rluvaton 3182a97
update with main
rluvaton 48aab96
move comment
rluvaton 039d073
format `Cargo.toml`
rluvaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed some reluctance in other PRs to pull in additional dependencies since the dependency graph is quite large already. Not sure what the policy is to accept or reject new ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The good thing is that this does not have any dependencies at all
https://github.com/whatisaphone/genawaiter/blob/45c10c223b92da215e182bc3eff0d5e09bf813f4/Cargo.toml#L17-L21
The only dependencies that we are using with the enabled
futuresfeature already exists