docs: Add SKILL.md for designing benchmark - #25285
Open
2010YOUY01 wants to merge 2 commits into
Open
2010YOUY01 wants to merge 2 commits into
2010YOUY01 wants to merge 2 commits into
Conversation
2010YOUY01
commented
Sep 14, 2026
|
|
||
| ## Rust microbenchmarks | ||
|
|
||
| TODO |
Contributor
Author
There was a problem hiding this comment.
I don't have ideas specific to Rust microbenchmarks; maybe others do and we can add them later.
Member
There was a problem hiding this comment.
It is better to remove this section entirely if we do not have the content ready. Otherwise, it may confuse agents.
Contributor
Author
There was a problem hiding this comment.
I agree. Removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25285 +/- ##
========================================
Coverage 81.90% 81.91%
========================================
Files 1134 1134
Lines 425217 425708 +491
Branches 425217 425708 +491
========================================
+ Hits 348289 348729 +440
- Misses 56288 56301 +13
- Partials 20640 20678 +38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2010YOUY01
commented
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Here is something I had in mind when designing or reviewing benchmarks. Summarize it as a doc for future reference.
What changes are included in this PR?
Add a skill for designing new benchmarks.
What is the testing strategy for this PR?
Are there any user-facing changes?