Skip to content

Bugfix: HLL4 written in rust cannot not be loaded in Java #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notfilippo merged 1 commit into from
May 19, 2026
+5 −2
Merged

Bugfix: HLL4 written in rust cannot not be loaded in Java #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions datasketches/src/hll/array4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ use crate::common::NumStdDev;
use crate::error::Error;
use crate::hll::Coupon;
use crate::hll::estimator::HipEstimator;
use crate::hll::serialization::COMPACT_FLAG_MASK;
use crate::hll::serialization::COUPON_SIZE_BYTES;
use crate::hll::serialization::CUR_MODE_HLL;
use crate::hll::serialization::HLL_PREAMBLE_SIZE;
Expand Down Expand Up @@ -388,8 +389,10 @@ impl Array4 {
bytes.write_u8(lg_config_k);
bytes.write_u8(0); // unused for HLL mode

// Write flags
let mut flags = 0u8;
// Write flags.
// COMPACT_FLAG_MASK is always set: aux map entries are written as a compact sequential
// list of populated entries only.
let mut flags = COMPACT_FLAG_MASK;
if self.estimator.is_out_of_order() {
flags |= OUT_OF_ORDER_FLAG_MASK;
}
Expand Down