-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[chore](thirdparty) Upgrade Apache Arrow to 24.0.0 #66221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,17 +48,25 @@ jobs: | |
| - 'be/**' | ||
| - 'gensrc/proto/**' | ||
| - 'gensrc/thrift/**' | ||
| thirdparty_changes: | ||
| - 'thirdparty/**' | ||
|
|
||
| - name: Ccache ${{ github.ref }} | ||
| if: ${{ github.event_name == 'schedule' || steps.filter.outputs.be_changes == 'true' }} | ||
| if: | | ||
| github.event_name == 'schedule' || | ||
| steps.filter.outputs.be_changes == 'true' || | ||
| steps.filter.outputs.thirdparty_changes == 'true' | ||
| uses: ./.github/actions/ccache-action | ||
| with: | ||
| key: BE-UT-macOS | ||
| max-size: "5G" | ||
| restore-keys: BE-UT-macOS- | ||
|
|
||
| - name: Build BE ${{ github.ref }} | ||
| if: ${{ github.event_name == 'schedule' || steps.filter.outputs.be_changes == 'true' }} | ||
| if: | | ||
| github.event_name == 'schedule' || | ||
| steps.filter.outputs.be_changes == 'true' || | ||
| steps.filter.outputs.thirdparty_changes == 'true' | ||
| run: | | ||
| cellars=( | ||
| 'm4' | ||
|
|
@@ -101,6 +109,17 @@ jobs: | |
| -o doris-thirdparty-prebuilt-darwin-arm64.tar.xz | ||
| fi | ||
| tar -xvf doris-thirdparty-prebuilt-darwin-arm64.tar.xz | ||
|
|
||
| # A thirdparty upgrade can make the shared prebuilt archive stale. | ||
| # Rebuild the changed Arrow/Paimon stack before compiling BE so this | ||
| # job validates the versions selected by the PR. | ||
| if [[ "${{ steps.filter.outputs.thirdparty_changes }}" == "true" ]]; then | ||
| curl -L https://github.com/apache/doris-thirdparty/releases/download/automation/doris-thirdparty-source.tgz \ | ||
| -o doris-thirdparty-source.tgz | ||
| tar -zxvf doris-thirdparty-source.tgz | ||
| export MACOSX_DEPLOYMENT_TARGET=12.0 | ||
| ./build-thirdparty.sh -j "$(nproc)" arrow paimon_cpp | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P1] Fetch xsimd 14 before this targeted Arrow build Passing only |
||
| fi | ||
| popd | ||
|
|
||
| # macos-15 runners are Apple Silicon (arm64), so the JDK env var is | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Align this broad trigger with the dependency set actually rebuilt
thirdparty_changesmatches every file underthirdparty/**, but this branch always rebuilds only Arrow and Paimon. For example, a protobuf version or patch change triggers this BE job while both Arrow and BE still consume protobuf from the shared prebuilt, so a green result would not validate the PR-selected dependency as the new comments imply. Please either narrow the filter to the Arrow/Paimon inputs this step covers or derive and rebuild the changed dependency set (including the required transitive closure).