branch-4.1: [fix](test) bound recycler polling waits - #66237
Draft
hello-stephen wants to merge 2 commits into
Draft
branch-4.1: [fix](test) bound recycler polling waits#66237hello-stephen wants to merge 2 commits into
hello-stephen wants to merge 2 commits into
Conversation
Contributor
Author
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
[branch41-macos13-runner-retirement] The BE UT (macOS) job is blocked by a shared workflow issue, not this PR:
Draft PR #66248 switches branch-4.1 to the supported Intel label After #66248 merges, this PR's macOS check still needs to be retriggered and reach a terminal result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add a 30-minute deadline to every unbounded Recycler/Checker polling loop under
cloud_p0/recycler.The change now covers all four unbounded loops across the three related cases:
test_recycler.groovy: wait for a Recycler round and wait for a Checker roundcheck_meta.groovy: wait for a successful Recycler roundtest_checker.groovy: wait for the expected Checker failureAll other Recycler cases already use bounded retry counters and are unchanged. When a service timestamp does not advance, the affected test now fails with the relevant timestamps instead of looping until TeamCity’s 24-hour build timeout.
Why
The branch-4.1 Recycler pipeline has repeatedly remained inside an unbounded polling loop with no test occurrence until TeamCity terminated the build after 1440 minutes (for example, builds 204533 and 204268). A normal successful
test_recyclerexecution in build 203828 took about 11 minutes, so a 30-minute per-phase deadline keeps reasonable headroom while turning an infrastructure/service stall into an actionable failure.This does not suppress a Recycler or Checker failure and does not change any success condition. It only bounds waits and preserves the last observed job timestamps in the error message.
Validation
git diff --checkregression-test/suites/cloud_p0/recycler: 4 unboundedwhile (true)loops across 3 files, all 4 now have timeout guardstest_recyclerduration in branch-4.1 build 203828Related: DORIS-27416