branch-4.1: [fix](job scheduler) Record task finish time on execution failure #66232 - #66271
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](job scheduler) Record task finish time on execution failure #66232#66271github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…6232) ### What problem does this PR solve? When a task fails through the execution exception path, `AbstractTask.runTask()` calls the no-argument `onFail()`, which marked the task FAILED without recording `finishTimeMs`. MTMV failed refresh tasks therefore exposed an empty FinishTime and could not calculate DurationMs. relate PR: #27703 ### What changes were made? - Record `finishTimeMs` when `AbstractTask.onFail()` transitions a task to FAILED. - Add a regression unit test covering the `runTask()` exception path and preserving the error message. ### Testing - `AbstractJobStatusTest`: 13 tests passed.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
|
run p0 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #66232