Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 17178 ms |
Contributor
TPC-DS: Total hot run time: 81860 ms |
Contributor
ClickBench: Total hot run time: 14.7 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
3 similar comments
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 16836 ms |
Contributor
TPC-DS: Total hot run time: 82740 ms |
Contributor
ClickBench: Total hot run time: 14.76 s |
Issue Number: None
Related PR: None
Problem Summary: Meta Service stores ALTER COMPUTE GROUP properties as a complete replacement, but the FE periodic checker merged only changed keys into its in-memory metadata. Properties removed from Meta Service therefore remained in FE indefinitely. Compare the complete snapshots and publish a validated replacement map so additions, updates, and removals converge consistently.
Compute group property removals now propagate from Meta Service to FE during periodic synchronization.
- Test: Unit Test
- CloudInstanceStatusCheckerTest#testSyncComputeGroupPropertiesRemovesKeysMissingFromMetaService
- fe-core Checkstyle
- Behavior changed: Yes (FE removes compute group properties absent from the authoritative Meta Service snapshot)
- Does this need documentation: No
deardeng
force-pushed
the
fix-doris-28801
branch
from
September 17, 2026 03:27
d15b1a6 to
8cf83dc
Compare
deardeng
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
September 17, 2026 03:27
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 27475 ms |
Contributor
TPC-DS: Total hot run time: 153890 ms |
Contributor
ClickBench: Total hot run time: 23.84 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary: Meta Service stores ALTER COMPUTE GROUP properties as a complete replacement, but the FE periodic checker merged only changed keys into its in-memory metadata. Properties removed from Meta Service therefore remained in FE indefinitely. Compare the complete snapshots and publish a validated replacement map so additions, updates, and removals converge consistently.
Compute group property removals now propagate from Meta Service to FE during periodic synchronization.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)