minor: release process by cecemei · Pull Request #18681 · apache/druid

cecemei · 2025-10-22T03:06:41Z

Release process.

This PR has:

github-actions · 2025-12-28T00:30:13Z

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

github-actions · 2026-01-25T00:30:31Z

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions · 2026-07-08T00:39:34Z

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

github-actions · 2026-08-06T00:33:58Z

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

kfaraz · 2026-10-01T03:32:54Z

        print("Tagging Pull Request {} with milestone {}".format(pr_number, milestone))
-        url = "https://api.github.com/repos/apache/druid/issues/{}".format(pr_number)
-        requests.patch(url, json=milestone_json, auth=(github_username, os.environ["GIT_TOKEN"]))
+        if os.environ.get("DRY_RUN", "true").lower() == "false":


Please call out the DRY_RUN env variable in the help text of this script and maybe in the comments too.

kfaraz · 2026-10-01T03:33:33Z


 ```bash
-$ git checkout origin/master
+$ git checkout origin/37.0.0


Please add a line above mentioning that this is for hotfix/minor version releases.

FrankChen021

🟡 Changes recommended

Reviewed all 4 of 4 changed files in the supplied merge-base diff. The release-guide changes were checked against the three modified helper scripts and the surrounding milestone/backport workflow; the scripts have no repository test coverage, so the assessment is static.

Validation: git diff --check was run on the four changed files and reported trailing whitespace on added documentation lines. No builds, installs, formatters, or broad tests were run, per the requested static-review scope.

Severity	Findings
P0	0
P1	1
P2	1
P3	1
Total	3

This is an automated review by Codex GPT-5.6-Luna(max)

After addressing the findings or replying to the comments, you can request another review from me to trigger a new automated review.

FrankChen021 · 2026-10-01T12:59:36Z

        print("Tagging Pull Request {} with milestone {}".format(pr_number, milestone))
-        url = "https://api.github.com/repos/apache/druid/issues/{}".format(pr_number)
-        requests.patch(url, json=milestone_json, auth=(github_username, os.environ["GIT_TOKEN"]))
+        if os.environ.get("DRY_RUN", "true").lower() == "false":


[P1] Default dry-run disables milestone tagging

Finding: A normal invocation now takes the DRY_RUN default of true, so every missing milestone is only reported and the GitHub PATCH is skipped. The release guide still presents this script as the tool that tags missing PRs, and find-missing-backports.py relies on those milestones; following the documented workflow therefore leaves PRs untagged and can make the later backport check silently incomplete.

Suggestion: Keep the normal invocation mutating (or add an explicit --dry-run opt-in) and document the safe preview mode separately.

FrankChen021 · 2026-10-01T12:59:36Z


 ```bash
-$ svn add 0.17.0-rc3
+$ cp ../druid-release/distribution/target/apache* ./37.0.0-rc1/.


[P2] Artifact copy targets a directory that was never created

Finding: Immediately after checking out dist/dev/druid, the documented command copies into ./37.0.0-rc1/., but no step creates that directory. From a clean checkout, cp fails with a missing-destination error and the release artifacts are never staged for svn add.

Suggestion: Create the release-candidate directory before copying, or use a checkout/copy command that creates the destination explicitly.

FrankChen021 · 2026-10-01T12:59:36Z

 ### Cancelling a vote

-If for any reason during the Druid PMC vote a blocking issue becomes apparent, a vote should be officially cancelled by sending an email with the following subject line: `[CANCEL][VOTE] Release Apache Druid 0.17.0 [RC3]` and the reasons for the cancellation in the body.
+If for any reason during the Druid PMC vote a blocking issue becomes apparent, a vote should be officially cancelled by sending an email with the following subject line: `[CANCEL][VOTE] Release Apache Druid 37.0.0 [RC3]` and the reasons for the cancellation in the body.


[P3] Cancellation template names the wrong release candidate

Finding: The voting and final-release instructions in this same guide use druid-37.0.0-rc2, but the cancellation subject was changed to 37.0.0 [RC3]. Copying the cancellation template for the documented vote would identify a different, likely nonexistent candidate and make the release-thread record inaccurate.

Suggestion: Use the same candidate placeholder/version as the vote and final-release examples, or make the RC number explicitly variable throughout the template.

FrankChen021

🟢 Approval recommended

Rechecked the three findings from the previous review against this head: the milestone script now applies tags by default and documents APPLY_TAGS=false preview mode, the release candidate directory is created before copying, and the cancellation subject matches the RC2 vote and final-release examples. One non-blocking issue remains: most links in the new checklist do not navigate because their fragments use uppercase letters while GitHub heading IDs are lowercase. This affects navigation only; the release instructions remain readable and can be corrected after merging.

Coverage: reviewed all 4 of 4 changed files: distribution/asf-release-process-guide.md, distribution/bin/find-missing-backports.py, distribution/bin/get-milestone-prs.py, and distribution/bin/tag-missing-milestones.py. Started with the incremental diff, then inspected the full diff and surrounding release workflow and scripts; rechecked all three prior findings.

Validation: git diff --check 443688fea12b1fee730f38f3aef87462573b475e...HEAD reported trailing whitespace on 10 added guide lines. The prepared worktree is clean. Static review only; no builds or tests were run.

Severity	Findings
P0	0
P1	0
P2	0
P3	1
Total	1

This is an automated review by Codex GPT-5.6-Luna(max)

After addressing the findings or replying to the comments, you can request another review from me to trigger a new automated review.

FrankChen021 · 2026-10-07T12:28:57Z

+## 🚀 Release Checklist
+
+- [ ] [Prior to starting, initial setup for release access](#prior-to-starting-initial-setup-for-release-access)
+  - [ ] [SVN access](#SVN-access)


[P3] Lowercase the checklist section fragments

Finding: The new checklist uses fragments such as #SVN-access, but GitHub generates lowercase heading IDs such as #svn-access. Most checklist links therefore do not jump to their sections, making the new navigation unreliable.

Suggestion: Lowercase each fragment so it matches the generated ID for its target heading.

cecemei added 4 commits October 21, 2025 20:06

release

41ee3a9

prior-to-starting

54b10b2

docs

975db02

35

dc19e1b

github-actions Bot added the stale label Dec 28, 2025

github-actions Bot closed this Jan 25, 2026

cecemei added 2 commits March 19, 2026 21:31

Merge branch 'master' into tag-milestone

63cc0ac

Merge branch 'master' into tag-milestone

369532f

cecemei reopened this Apr 8, 2026

github-actions Bot removed the stale label Apr 9, 2026

cecemei added 5 commits April 10, 2026 14:32

format

67c5105

release

bd8ba49

Merge branch 'master' into tag-milestone

5b49469

release

c5f51c9

Merge branch 'master' into tag-milestone

fe61b84

cecemei changed the title ~~release~~ minor: release process May 8, 2026

github-actions Bot added the stale label Jul 8, 2026

github-actions Bot closed this Aug 6, 2026

Merge remote-tracking branch 'origin/master' into tag-milestone

f393469

cecemei reopened this Sep 30, 2026

cecemei marked this pull request as ready for review September 30, 2026 16:18

github-actions Bot removed the stale label Oct 1, 2026

kfaraz approved these changes Oct 1, 2026

View reviewed changes

FrankChen021 reviewed Oct 1, 2026

View reviewed changes

review

3162459

FrankChen021 reviewed Oct 7, 2026

View reviewed changes

lowercase

a703a4d

Navigation Menu

Repository navigation

minor: release process - #18681

minor: release process#18681
cecemei wants to merge 14 commits into
apache:masterfrom
cecemei:tag-milestone

cecemei commented Oct 22, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 28, 2025

Uh oh!

github-actions Bot commented Jan 25, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

kfaraz Oct 1, 2026

Uh oh!

kfaraz Oct 1, 2026

Uh oh!

FrankChen021 left a comment

Uh oh!

FrankChen021 Oct 1, 2026

Uh oh!

FrankChen021 Oct 1, 2026

Uh oh!

FrankChen021 Oct 1, 2026

Uh oh!

FrankChen021 left a comment

Uh oh!

FrankChen021 Oct 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cecemei commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 28, 2025

Uh oh!

github-actions Bot commented Jan 25, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

kfaraz Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

kfaraz Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

FrankChen021 left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

FrankChen021 Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

FrankChen021 Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

FrankChen021 Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

FrankChen021 left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

FrankChen021 Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cecemei commented Oct 22, 2025 •

edited

Loading