Fix router rule config chain alignment - #1528
Draft
xiaobaicai66695 wants to merge 2 commits into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Backend:
/dubbo/config/dubbo/{ruleName}so dubbo-go's default ZK config-center group can consume admin-issued router rules./dubbo/config/{ruleName}compatibility for discovery parsing and deletion/migration cleanup.Frontend:
{application}.tag-router, which is the key dubbo-go tag router subscribes to.Why
The admin console could persist router rules, but the Zookeeper path/key contract did not fully match dubbo-go's dynamic config subscriptions. This fixes the rule delivery chain first, before expanding the remaining router capability gaps such as a complete admin affinity-rule UI/API flow.
Validation
make fmtgo test ./pkg/governor/zk ./pkg/discovery/zk ./pkg/console/servicego test ./...cd ui-vue3 && yarn test addByFormView.spec.ts addByYAMLView.spec.ts updateByFormView.spec.tscd ui-vue3 && yarn vite buildKnown validation note:
make check-fmtcould not run because the current Makefile has nocheck-fmttarget (make: *** ???????????check-fmt?? ???).yarn vite buildstill reports existing warnings aboutupdateInstanceTrafficSwitchnot being exported fromsrc/api/service/instance.tsand large chunks.Screenshots: