Skip to content

Fix router rule config chain alignment - #1528

Draft
xiaobaicai66695 wants to merge 2 commits into
apache:developfrom
xiaobaicai66695:feature/admin-router-rule-chain
Draft

Fix router rule config chain alignment#1528
xiaobaicai66695 wants to merge 2 commits into
apache:developfrom
xiaobaicai66695:feature/admin-router-rule-chain

Conversation

@xiaobaicai66695

Copy link
Copy Markdown

What

Backend:

  • Write Zookeeper rule configs under /dubbo/config/dubbo/{ruleName} so dubbo-go's default ZK config-center group can consume admin-issued router rules.
  • Keep legacy /dubbo/config/{ruleName} compatibility for discovery parsing and deletion/migration cleanup.
  • Add tests for grouped ZK rule paths and config node-name parsing.

Frontend:

  • Align tag-rule creation from form and YAML views to generate {application}.tag-router, which is the key dubbo-go tag router subscribes to.
  • Add Vitest coverage for tag rule form/YAML rule-name generation.

Why

The admin console could persist router rules, but the Zookeeper path/key contract did not fully match dubbo-go's dynamic config subscriptions. This fixes the rule delivery chain first, before expanding the remaining router capability gaps such as a complete admin affinity-rule UI/API flow.

Validation

  • make fmt
  • go test ./pkg/governor/zk ./pkg/discovery/zk ./pkg/console/service
  • go test ./...
  • cd ui-vue3 && yarn test addByFormView.spec.ts addByYAMLView.spec.ts updateByFormView.spec.ts
  • cd ui-vue3 && yarn vite build

Known validation note:

  • make check-fmt could not run because the current Makefile has no check-fmt target (make: *** ???????????check-fmt?? ???).
  • yarn vite build still reports existing warnings about updateInstanceTrafficSwitch not being exported from src/api/service/instance.ts and large chunks.

Screenshots:

  • Not attached yet; PR is draft until runtime screenshot validation is added.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant