FINERACT-2455: WC - Transaction Type - Accrual and accrual handling#6117
Open
mariiaKraievska wants to merge 2 commits into
Open
Conversation
mariiaKraievska
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
from
July 10, 2026 10:24
ed6ec41 to
7f2d0c2
Compare
alberto-art3ch
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
3 times, most recently
from
July 15, 2026 06:00
fc0b42b to
081e5dc
Compare
alberto-art3ch
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
2 times, most recently
from
July 17, 2026 05:16
edea87e to
e132970
Compare
ruzeynalov
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
from
July 17, 2026 12:25
91e3bbb to
3389ad4
Compare
alberto-art3ch
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
from
July 17, 2026 14:07
3389ad4 to
9662310
Compare
ruzeynalov
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
from
July 17, 2026 15:59
9662310 to
520bf5b
Compare
alberto-art3ch
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
from
July 19, 2026 12:48
520bf5b to
c78fb5c
Compare
adamsaghy
marked this pull request as ready for review
July 20, 2026 10:15
mariiaKraievska
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
2 times, most recently
from
July 20, 2026 11:05
1ffdea8 to
0873db4
Compare
Contributor
|
@mariiaKraievska please rebase |
… and expectation fixes after rebase Restores the QA test layer dropped by the PR rebase (was 293586f): - TestRailIds C85589-C85603 on all charge accrual scenarios - scenario hardening: pre-due-date boundary COB, idempotency re-run, closure/repayment/reversal journal entry assertions, re-disbursement re-accrual cycle - adjustment-after-accrual (submitted-date) and NONE-accounting negative scenarios - goodwill/allocation expectation fixes for closure accruals (COB runs with business date - 1; closure accruals post after the closing transaction) - After-hook restoring charge-accrual-date to due-date even when a scenario fails mid-way
mariiaKraievska
force-pushed
the
FINERACT-2455/wc-charge-income-accrual-and-accrual-handling
branch
from
July 20, 2026 13:08
0873db4 to
d33c0b6
Compare
adamsaghy
reviewed
Jul 20, 2026
|
|
||
| final WorkingCapitalLoanTransactionAllocation allocation = transactionProcessor.processRepaymentLikeTransaction(loan, transaction, | ||
| transactionType, transactionDate, transactionAmount); | ||
| final WorkingCapitalLoanBalance balance = this.balanceRepository.findByWcLoan_Id(loan.getId()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.