Skip to content

[FLINK-40574][build] Update SLF4J from 1.7.36 to 2.0.19 - #29120

Open
piotrp wants to merge 1 commit into
apache:masterfrom
piotrp:slf4j2
Open

[FLINK-40574][build] Update SLF4J from 1.7.36 to 2.0.19#29120
piotrp wants to merge 1 commit into
apache:masterfrom
piotrp:slf4j2

Conversation

@piotrp

@piotrp piotrp commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Update of SLF4J dependency to current version:

  • makes dependency management easier for projects that build on Flink or use Logback
  • prevents possible issues if a library Flink depends on starts using new SLF4J APIs

Brief change log

Updated SLF4J 1.7.36 to 2.0.19. New version has compatible API, only Log4J binding must use a different dependency (log4j-slf4j-impl -> log4j-slf4j2-impl).

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes - for deployments that replace logging libraries
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

Update to Chinese documentation is fully AI-generated.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code

@flinkbot

flinkbot commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@piotrp piotrp changed the title [FLINK-XXXX] Update SLF4J from 1.7.36 to 2.0.19 [FLINK-40574] Update SLF4J from 1.7.36 to 2.0.19 Sep 6, 2026
@piotrp
piotrp marked this pull request as ready for review September 7, 2026 08:09

@spuru9 spuru9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-scoped SLF4J 1.7.36 -> 2.0.19 bump: NOTICE files and EN/ZH docs are updated consistently.

minor: the commit message is just "Update SLF4J from 1.7.36 to 2.0.19" - missing the [FLINK-40574][build] prefix and Generated-by trailer that AGENTS.md asks for (both are present in the PR title/description, just not the actual commit). Worth fixing before merge.

@piotrp piotrp changed the title [FLINK-40574] Update SLF4J from 1.7.36 to 2.0.19 [FLINK-40574][build] Update SLF4J from 1.7.36 to 2.0.19 Sep 7, 2026
@piotrp

piotrp commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Prefix and trailer added

@spuru9 spuru9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Sep 7, 2026
@Samrat002

Copy link
Copy Markdown
Contributor

Why not use the latest version 2.26.1?

@piotrp

piotrp commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Because this is about SLF4J, not Log4j. I didn't want to mix multiple changes in one PR.

Edit: and Log4j is already at 2.26.1...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants