[FLINK-40574][build] Update SLF4J from 1.7.36 to 2.0.19 - #29120
Open
piotrp wants to merge 1 commit into
Open
Conversation
Collaborator
piotrp
marked this pull request as ready for review
September 7, 2026 08:09
spuru9
approved these changes
Sep 7, 2026
Contributor
There was a problem hiding this comment.
Clean, well-scoped SLF4J 1.7.36 -> 2.0.19 bump: NOTICE files and EN/ZH docs are updated consistently.
minor: the commit message is just "Update SLF4J from 1.7.36 to 2.0.19" - missing the [FLINK-40574][build] prefix and Generated-by trailer that AGENTS.md asks for (both are present in the PR title/description, just not the actual commit). Worth fixing before merge.
Generated-by: Claude Code (Opus 5)
Contributor
Author
|
Prefix and trailer added |
Contributor
|
Why not use the latest version 2.26.1? |
Contributor
Author
|
Because this is about SLF4J, not Log4j. I didn't want to mix multiple changes in one PR. Edit: and Log4j is already at 2.26.1... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Update of SLF4J dependency to current version:
Brief change log
Updated SLF4J 1.7.36 to 2.0.19. New version has compatible API, only Log4J binding must use a different dependency (
log4j-slf4j-impl->log4j-slf4j2-impl).Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Update to Chinese documentation is fully AI-generated.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code