[hotfix][table] Fix tryParseJson() docs to say NULL instead of throws an error - #29124
Merged
Conversation
… an error FLINK-40545 copy-pasted the parseJson() wording into tryParseJson(), so the allowDuplicateKeys=false branch claimed the TRY variant throws an error. TRY_PARSE_JSON catches all parse errors, including duplicate-key errors, and returns NULL instead of throwing, so the Java Javadoc, Python docstring, and sql_functions.yml description are corrected to match. Also trims a trailing-whitespace line in sql_functions.yml picked up in the same block.
Collaborator
spuru9
approved these changes
Sep 7, 2026
twalthr
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes incorrect documentation for
tryParseJson(allowDuplicateKeys)introduced in FLINK-40545 (bf4a71a). The Javadoc, Python docstring, andsql_functions.ymlentry were copy-pasted fromparseJson()and wrongly claimed thefalsebranch "throws an error." SinceTRY_PARSE_JSONcatches all parse errors and returnsNULL, the docs now match that contract.Brief change log
BaseExpressions.java: fix Javadoc fortryParseJson(boolean)expression.py: fix docstring fortry_parse_jsonsql_functions.yml: fix description text, trim a trailing-whitespace lineVerifying this change
Docs-only change, no test coverage needed.
Does this pull request potentially affect one of the following parts:
Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: [Tool Name and Version]