[build] Fix Gateway 1.0 release provenance and verification - #4306
Merged
Merged
Conversation
beryllw
force-pushed
the
gateway/1.0-release-audit
branch
from
September 11, 2026 10:41
e8a9d70 to
65631fc
Compare
Contributor
Author
|
@leekeiabstraction @fresh-borzoni @naivedogger Could you please help review this PR? |
naivedogger
approved these changes
Sep 11, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@beryllw Thank you for the PR, left some comments, PTAL
| Next, we need to build and push Docker images for the release candidates. This will enable users to easily test the new functionality using the Quickstart guide in the [Fluss documentation](https://fluss.apache.org/docs/quickstart/flink/) improving accessibility and feedback during the release validation phase. | ||
|
|
||
| From the root directory of the source code, run the following commands to build and push the fluss Docker image. | ||
| On the image-build machine, export the recorded `RELEASE_COMMIT` and verify |
Member
There was a problem hiding this comment.
Steps 3 and 7 need the build machine to be on RELEASE_COMMIT. The tag isn't pushed until line 586.
So a second machine doesn't have that commit, and create_gateway_release.sh:63 stops.
Should we correct the ordering then?
| RELEASE_DIR="${GATEWAY_RELEASE_DIR:-${FLUSS_DIR}/tools/releasing/release}" | ||
|
|
||
| if [[ "${SKIP_GPG}" == "false" ]]; then | ||
| if [[ -z "${RELEASE_COMMIT:-}" ]]; then |
Member
There was a problem hiding this comment.
Local builds now fail with RELEASE_COMMIT must be the full commit hash recorded for the RC tag.
Shall we add SKIP_GPG=true to the message?
fresh-borzoni
approved these changes
Sep 14, 2026
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@beryllw Thank you, LGTM, merging 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix release verification errors and prevent Gateway artifacts from different release candidates being mixed.
Linked issue: close #xxx
Brief change log
Tests
API and Format
No API or storage-format changes. Signed Gateway archives include RELEASE_COMMIT metadata.
Documentation
Updated release creation and verification guides.