Skip to content

[test] Remove redundant merge-engine alter test from AlterBucketNumTest #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kaixuan-Duan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[test] Remove redundant merge-engine alter test from AlterBucketNumTest #4322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions fluss-server/src/test/java/org/apache/fluss/server/coordinator/AlterBucketNumTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,55 +509,6 @@ void testAlterBucketNumRejectedOnAggregationTable() throws Exception {
assertThat(partition.get().getBucketCount()).isEqualTo(originalBucketCount);
}

@Test
void testAlterMergeEngineToAggregationRejectedAfterRescale() throws Exception {
// The reverse direction of the mutual exclusion: 'table.merge-engine' is not alterable,
// so a rescaled table can never switch to the aggregation merge engine afterwards. If
// altering the merge engine ever becomes supported, this test reminds that change to
// keep rejecting the switch to aggregation on rescaled tables (epoch > 0).
TablePath tablePath = TablePath.of(DEFAULT_DB, "test_reject_aggregation_after_rescale");
int originalBucketCount = 4;
TableAssignment tableAssignment =
generateAssignment(originalBucketCount, 3, getTabletServers());
metadataManager.createTable(
tablePath,
remoteDataDir,
partitionedPrimaryKeyTable(originalBucketCount, null),
tableAssignment,
false);
TableInfo tableInfo = metadataManager.getTable(tablePath);
metadataManager.createPartition(
tablePath,
tableInfo.getTableId(),
remoteDataDir,
new PartitionAssignment(
tableInfo.getTableId(), tableAssignment.getBucketAssignments()),
fromPartitionName(tableInfo.getPartitionKeys(), "2024-01"),
false,
originalBucketCount);

// Rescale the default-engine table first, which advances the bucketCountEpoch.
alterBucketNum(metadataManager, tablePath, 8);
assertThat(metadataManager.getTable(tablePath).getBucketCountEpoch()).isEqualTo(1L);

// Switching the rescaled table to the aggregation merge engine must be rejected.
assertThatThrownBy(
() ->
alterMergeEngine(
metadataManager,
tablePath,
MergeEngineType.AGGREGATION.name()))
.isInstanceOf(InvalidAlterTableException.class)
.hasMessageContaining("'table.merge-engine'")
.hasMessageContaining("not supported to alter yet");

// The merge engine is untouched and the bucket layout stays at the rescaled state.
assertThat(metadataManager.getTable(tablePath).getTableConfig().getMergeEngineType())
.isEmpty();
assertThat(metadataManager.getTable(tablePath).getNumBuckets()).isEqualTo(8);
assertThat(metadataManager.getTable(tablePath).getBucketCountEpoch()).isEqualTo(1L);
}

// ========================== Success Tests ==========================

@ParameterizedTest(name = "bucketNum {0} -> {1}")
Expand Down Expand Up @@ -1069,22 +1020,6 @@ private static TableDescriptor partitionedPrimaryKeyTable(int bucketCount, Strin
return builder.build().withReplicationFactor(3);
}

private static void alterMergeEngine(
MetadataManager manager, TablePath tablePath, String mergeEngine) {
String key = ConfigOptions.TABLE_MERGE_ENGINE.key();
TablePropertyChanges.Builder builder = TablePropertyChanges.builder();
builder.setTableProperty(key, mergeEngine);
manager.alterTableProperties(
tablePath,
Collections.singletonList(TableChange.set(key, mergeEngine)),
builder.build(),
false,
null,
(currentTable, updatedTable) -> {},
(currentTable, updatedTable) -> {},
ZkVersion.MATCH_ANY_VERSION.getVersion());
}

private static void alterBucketNum(
MetadataManager manager, TablePath tablePath, int newBucketCount) {
manager.alterBucketCount(
Expand Down
Loading