Repository navigation
refactor: convert grails-bootstrap to Groovy - #16578
borinquenkid wants to merge 16 commits into
Conversation
GrailsEclipseConsole lost the 'throws IOException' of its public constructor in the conversion (the implicit Groovy default constructor declares none), so Java callers catching IOException would stop compiling. Declare it explicitly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…y-grails-bootstrap
…y-grails-bootstrap
…-groovy-grails-bootstrap
…o-groovy-grails-bootstrap
…-to-groovy-grails-bootstrap
…-to-groovy-grails-bootstrap
…-to-groovy-grails-bootstrap
…y-grails-bootstrap AntPathMatcher.groovy takes upstream c471280 (combine patterns and extract template variables as AntPathMatcher documents), ported into the Groovy file. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…-to-groovy-grails-bootstrap
|
SUPERSEDED: the Temporary CI flag on this stacked branch (BLOCKER before merge). This Java-to-Groovy chain is a stack of PRs, and every push to any of them starts the full CI matrix, which is more runner time than the ASF allows us. Every PR in the stack except the one closest to its release branch (#16576) therefore carries one temporary commit, With it, CI on this PR compiles but does not run tests or code style. The full build runs on #16576 (closest to 10.0.x), and each PR gets it when the PR below it has merged. Condition for merging this PR: that |
…-to-groovy-grails-bootstrap
|
Update: this branch now carries a different temporary CI commit (BLOCKER before merge). The earlier In its place, every PR in this stack except #16576 (the one closest to 10.0.x) carries one temporary commit, Condition for merging this PR: that commit must be reverted on this branch first ( |
…-to-groovy-grails-bootstrap
…/java-to-groovy-grails-bootstrap
…-to-groovy-grails-bootstrap
…-to-groovy-grails-bootstrap
🔎 No tests executed 🔎🏷️ Commit: b72e22b Learn more about TestLens at testlens.app/docs. |
What
Converts the remaining Java sources of
grails-bootstrapto Groovy: 28.javafiles removed, 29.groovyfiles added (29 files changed, 1668 insertions(+), 1612 deletions(-)).Why
The maintainers asked on #16351 for the Java-to-Groovy migration to land one Gradle project at a time as a stack of PRs, bottom-up in dependency order. #16572 did
grails-data-hibernate7; this PR is 3 of 30 in the next stack (base:refactor/java-to-groovy-core-leaves). The end state of every file is taken from the9.0.x-java-to-groovybranch, which already carries the regression fixes found by CI.Commits:
Changed outside the converted sources
Java-facing API sweep
Every deleted
.javawas compared with its Groovy twin viajavap -v -protected(class declaration, public/protected fields, constructors, methods incl. modifiers/throws/generics, interface default methods, nested class modifiers, and the annotations callers see). Result:grails-bootstrap: 28 deleted .java, 2 difference(s) found and fixed in this PR (see thefix:commit), 0 leftSee also the notes below. Remaining informational entries (widened visibility, e.g. Groovy property accessors): 3.
Verification
classesandtestClasses(plusast/cli/testFixturessource sets where present) of the converted project(s) and of their direct dependents compile: ['grails-core', 'grails-datamapping-support', 'grails-shell-cli', 'grails-spring', 'grails-spring-security', 'grails-spring-security-oauth2', 'grails-startup-progress', 'grails-test-suite-base', 'grails-test-suite-persistence', 'grails-views-core']codeStyle,ratand a whole-repobuild -PskipTestsare run once on the tip of the stack.Notes
MIN_VALUE/MAX_VALUE/next()/previous(), property accessors appear for formerly package-private members, nested static classes with implicit constructors become public (they wereprotected), and generic type parameters that Groovy erases in constructors/methods (descriptors identical).static finalwithoutpubliccreates a property;==callsequals(); Closure/SAM coercions;@CompileStaticwith nested classes. All CI regression fixes found on the umbrella branch are included in the end state.🤖 Generated with Claude Code