[borinquenkid]

What

Converts the remaining Java sources of grails-gsp-core to Groovy: 51 .java files removed, 51 .groovy files added (57 files changed, 3917 insertions(+), 3889 deletions(-)).

Why

The maintainers asked on #16351 for the Java-to-Groovy migration to land one Gradle project at a time as a stack of PRs, bottom-up in dependency order. #16572 did grails-data-hibernate7; this PR is 17 of 30 in the next stack (base: refactor/java-to-groovy-grails-taglib). The end state of every file is taken from the 9.0.x-java-to-groovy branch, which already carries the regression fixes found by CI.

Commits:

• fa3b80a fix: keep the Java-facing API of the converted grails-gsp-core classes
• fad1efd refactor: convert grails-gsp-core to Groovy

Changed outside the converted sources

• nothing

Java-facing API sweep

Every deleted .java was compared with its Groovy twin via javap -v -protected (class declaration, public/protected fields, constructors, methods incl. modifiers/throws/generics, interface default methods, nested class modifiers, and the annotations callers see). Result:

• grails-gsp-core: 51 deleted .java, 5 difference(s) found and fixed in this PR (see the fix: commit), 0 left

See also the notes below. Remaining informational entries (widened visibility, e.g. Groovy property accessors): 40.

Verification

• classes and testClasses (plus ast/cli/testFixtures source sets where present) of the converted project(s) and of their direct dependents compile: ['grails-gsp', 'grails-mail', 'grails-web-common', 'grails-web-gsp', 'grails-web-taglib']
• No test suites were run locally (the umbrella branch was verified; CI runs them). codeStyle, rat and a whole-repo build -PskipTests are run once on the tip of the stack.

Notes

• Informational sweep entries that are not regressions: Groovy enums gain MIN_VALUE/MAX_VALUE/next()/previous(), property accessors appear for formerly package-private members, nested static classes with implicit constructors become public (they were protected), and generic type parameters that Groovy erases in constructors/methods (descriptors identical).
• Groovy gotchas that applied (see build: migrate remaining Java sources to Groovy #16351): static final without public creates a property; == calls equals(); Closure/SAM coercions; @CompileStatic with nested classes. All CI regression fixes found on the umbrella branch are included in the end state.
• Accepted: GSPWriter.write(char[], int, int) was an override that only called super; inherited unchanged from java.io.PrintWriter.

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[codecov]

Codecov Report

❌ Patch coverage is 64.05761% with 574 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.2969%. Comparing base (061756c) to head (89a0300).

Files with missing lines	Patch %	Lines
.../gsp/compiler/transform/LineNumberTransform.groovy	0.0000%	137 Missing ⚠️
...vy/org/grails/gsp/GroovyPagesTemplateEngine.groovy	66.6667%	59 Missing and 10 partials ⚠️
.../org/grails/gsp/io/DefaultGroovyPageLocator.groovy	57.7778%	51 Missing and 6 partials ⚠️
...in/groovy/org/grails/gsp/GroovyPageMetaInfo.groovy	72.0238%	41 Missing and 6 partials ⚠️
...e/src/main/groovy/org/grails/gsp/GroovyPage.groovy	84.6994%	17 Missing and 11 partials ⚠️
...mpiler/transform/GroovyPageOptimizerVisitor.groovy	0.0000%	28 Missing ⚠️
...c/main/groovy/org/grails/gsp/compiler/Strip.groovy	20.8333%	19 Missing ⚠️
...in/groovy/org/grails/gsp/GroovyPageWritable.groovy	79.0124%	13 Missing and 4 partials ⚠️
...ails/gsp/io/GroovyPageStaticResourceLocator.groovy	0.0000%	16 Missing ⚠️
...rg/grails/gsp/compiler/tags/GroovySyntaxTag.groovy	80.7692%	5 Missing and 10 partials ⚠️
... and 25 more

Additional details and impacted files

@@                               Coverage Diff                               @@
##             refactor/java-to-groovy-grails-taglib     #16595        +/-   ##
===============================================================================
- Coverage                                  63.3226%   63.2969%   -0.0258%     
- Complexity                                   31058      31392       +334     
===============================================================================
  Files                                         2238       2238                
  Lines                                       109359     109255       -104     
  Branches                                     20405      20441        +36     
===============================================================================
- Hits                                         69249      69155        -94     
+ Misses                                       30550      30518        -32     
- Partials                                      9560       9582        +22     

Files with missing lines	Coverage Δ
.../grails/gsp/aot/PrecompiledPageRuntimeHints.groovy	100.0000% <100.0000%> (ø)
...rails/gsp/compiler/GrailsLayoutPreprocessor.groovy	100.0000% <100.0000%> (ø)
...vy/org/grails/gsp/compiler/GroovyPageParser.groovy	79.4370% <ø> (ø)
...ails/gsp/compiler/tags/GroovyConditionalTag.groovy	100.0000% <100.0000%> (ø)
...g/grails/gsp/compiler/tags/GroovyFindAllTag.groovy	100.0000% <100.0000%> (ø)
...vy/org/grails/gsp/compiler/tags/GroovyIfTag.groovy	100.0000% <100.0000%> (ø)
.../org/grails/gsp/compiler/tags/GroovyEachTag.groovy	90.0000% <85.7143%> (ø)
...rg/grails/gsp/compiler/tags/GroovyElseIfTag.groovy	90.9091% <88.8889%> (ø)
.../org/grails/gsp/compiler/tags/GroovyElseTag.groovy	85.7143% <80.0000%> (ø)
...rg/grails/gsp/compiler/tags/GroovyUnlessTag.groovy	85.7143% <83.3333%> (ø)
... and 31 more

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[borinquenkid]

SUPERSEDED: the skipTests/skipCodeStyle flag described below was removed. See the newer comment about the CHANGEME FOR ACCEPTANCE workflow-trigger commit, which is the only temporary CI change on this branch.

Temporary CI flag on this stacked branch (BLOCKER before merge).

This Java-to-Groovy chain is a stack of PRs, and every push to any of them starts the full CI matrix, which is more runner time than the ASF allows us. Every PR in the stack except the one closest to its release branch (#16576) therefore carries one temporary commit, CHANGEME FOR ACCEPTANCE, that adds this to the root gradle.properties:

skipTests=true
skipCodeStyle=true

With it, CI on this PR compiles but does not run tests or code style. The full build runs on #16576 (closest to 10.0.x), and each PR gets it when the PR below it has merged.

Condition for merging this PR: that gradle.properties block (and the CHANGEME FOR ACCEPTANCE commit) must be dropped from this branch first, and CI must then be green with the tests running. A green check on this PR as it stands does not mean the tests ran. Rollout of the commit is branch by branch, so a branch may not carry it yet.

[borinquenkid]

Update: this branch now carries a different temporary CI commit (BLOCKER before merge).

The earlier skipTests/skipCodeStyle flag in gradle.properties did not help enough: the functional jobs still compile the whole repository (about 57 minutes each) on every push, so it only saved around a fifth of the time. It has been removed.

In its place, every PR in this stack except #16576 (the one closest to 10.0.x) carries one temporary commit, CHANGEME FOR ACCEPTANCE: disable PR workflow triggers. It changes the pull_request: trigger of each workflow to branches: ['CHANGEME-FOR-ACCEPTANCE'], a branch that does not exist, so pushing, rebasing or force-pushing this branch starts no jobs.

Condition for merging this PR: that commit must be reverted on this branch first (git revert of the CHANGEME FOR ACCEPTANCE commit), and CI must then run and be green. The absence of CI checks on this PR is deliberate and does not mean the code was tested. The full build runs on #16576, and each PR gets it when the PR below it has merged.

[testlens-app]

🔎 No tests executed 🔎

🏷️ Commit: a5a4233
▶️ Tests: 0 executed
⚪️ Checks: 45/45 completed

---

Learn more about TestLens at testlens.app/docs.