Repository navigation
refactor(grails-data-hibernate7): idiomatic Groovy cleanup of the J2G output - #16678
Open
borinquenkid wants to merge 2 commits into
Open
borinquenkid wants to merge 2 commits into
borinquenkid wants to merge 2 commits into
Conversation
borinquenkid
marked this pull request as ready for review
October 20, 2026 02:09
borinquenkid
changed the base branch from
refactor/java-to-groovy-grails-data-hibernate7
to
9.0.x-remove-h5
October 20, 2026 20:45
… partial The stage-2 conversion of grails-data-hibernate7 kept semicolons, double quotes and Java idioms to preserve rename similarity against the original .java. This pass makes 51 of those files read as Groovy: no semicolons, single-quoted plain strings, property access, Groovy truth where a Groovy File is not involved, and no `.class` on class references. No behaviour change: the module's suite is the safety net. Rebuilt on 9.0.x-h7-improvement-phase3 after the Hibernate 5 removal was withdrawn (#16350 is closed: Hibernate 5 stays through Grails 10), so the branch no longer carries the removal commits. It carries the 2026-10-22 upstream ports (tenant filter on every to-many, count-only queries without orders, enum unique groups over every member column) as merged.
borinquenkid
force-pushed
the
groovyism/hibernate7
branch
from
October 22, 2026 19:03
6d4fb68 to
9b5ac05
Compare
borinquenkid
changed the base branch from
9.0.x-remove-h5
to
9.0.x-h7-improvement-phase3
October 22, 2026 19:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #16572 (java-to-groovy conversion for
grails-data-hibernate7).Idiom pass over that conversion's output: the conversion PR keeps the original Java semicolons and double-quoted strings, under a
@SuppressWarnings('UnnecessarySemicolon')header and aTODO(groovyism-cleanup)comment, so git still recognizes each.java->.groovypair as a rename (see matrei's review on #16576). This PR removes that scaffolding and applies the Groovy idioms CodeNarc expects.Verification
CI note: this stacked branch inherits the temporary
CHANGEME FOR ACCEPTANCEworkflow-trigger commit from its base, so no CI runs on it. That commit must be reverted, and CI green, before this PR merges (blocker).🤖 Generated with Claude Code