Repository navigation
refactor(spring-security): idiomatic Groovy cleanup of the J2G output - #16684
Open
borinquenkid wants to merge 49 commits into
Open
borinquenkid wants to merge 49 commits into
borinquenkid wants to merge 49 commits into
Conversation
…-groovy-datamapping-validation
…tor/java-to-groovy-grails-datamapping-core
…ctor/java-to-groovy-grails-encoder
…-to-groovy-runtime-small
…to-groovy-datamapping-satellites
…tor/java-to-groovy-grails-data-mongodb
…/java-to-groovy-grails-data-neo4j
…ava-to-groovy-grails-taglib
…/refactor/java-to-groovy-grails-gsp-core # Conflicts: # grails-gsp/core/src/main/groovy/org/grails/gsp/compiler/GroovyPageParser.groovy
…a-to-groovy-grails-web-common
…ava-to-groovy-grails-converters
…ava-to-groovy-web-databinding-taglib
…tor/java-to-groovy-grails-web-url-mappings
…ctor/java-to-groovy-web-mvc-core
…o-groovy-grails-web-jsp
…-to-groovy-web-small
…roovy-web-controllers
…a-to-groovy-gsp-plugin-modules
…java-to-groovy-test-cache-scaffolding
…tor/java-to-groovy-spring-security
…o-groovy-datamapping-validation
…ctor/java-to-groovy-grails-datamapping-core
…actor/java-to-groovy-grails-encoder
…a-to-groovy-runtime-small
…-to-groovy-datamapping-satellites
…ctor/java-to-groovy-grails-data-mongodb
…r/java-to-groovy-grails-data-neo4j
…java-to-groovy-grails-taglib
…-to-groovy-grails-gsp-core
…va-to-groovy-grails-web-common
…java-to-groovy-grails-converters
…java-to-groovy-web-databinding-taglib
…ctor/java-to-groovy-grails-web-url-mappings
…actor/java-to-groovy-web-mvc-core
…to-groovy-grails-web-jsp
…a-to-groovy-web-small
…groovy-web-controllers # Conflicts: # grails-controllers/src/main/groovy/org/grails/plugins/web/controllers/GrailsSecurityHeadersFilter.groovy
…va-to-groovy-gsp-plugin-modules
…/java-to-groovy-test-cache-scaffolding
…ctor/java-to-groovy-spring-security
…sition Idiomatic Groovy pass over the Java-to-Groovy conversion output for the acl/plugin, oauth2/plugin, and plugin modules (7 files reviewed). - SecurityFilterPosition: `this.order` in the no-arg constructor and in getOrder() had no shadowing local/parameter, so `this.` was dropped (unambiguous `this.x`, per the groovyisms mapping table). The parameterized constructor keeps `this.order = order`, where the parameter does shadow the field. getOrder()'s signature is unchanged (verified with javap); no API or behaviour change. - AclVoter / AclVoters: annotation types (`@interface`) with no method bodies; nothing to idiomize. - OAuth2Exception: two constructors that only call `super(...)`; already idiomatic, no change. - AclVoterAnnotationsSpec, OAuth2ExceptionSpec, SecurityFilterPositionSpec: already written in idiomatic Groovy (single quotes, `==`, `.is()`, `*.order`, `sort(false)`, `findAll`/`every`); no Java leftover shapes to fix, left untouched. Verification: compileGroovy/compileTestGroovy clean for grails-spring-security, grails-spring-security-acl, grails-spring-security-oauth2; codeStyle (checkstyle + CodeNarc) clean for all three; full test task green (224/0 spring-security, 5/0 acl, 1/0 oauth2); javap dynamic-dispatch audit on SecurityFilterPosition.class clean (only harmless castToType/despreadList/selectConstructorAndTransformArguments/initMetaClass, no GroovyObject property/invoke fallbacks); downstream consumers (cas, ldap, rest/core, rest/gorm, rest/grailscache, rest/memcached, rest/redis, ui) compileGroovy clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…/spring-security # Conflicts: # grails-controllers/src/main/groovy/org/grails/plugins/web/controllers/GrailsSecurityHeadersFilter.groovy
borinquenkid
marked this pull request as ready for review
October 20, 2026 02:09
…m/spring-security
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #16610 (java-to-groovy conversion for
spring-security).Idiom pass over that conversion's output: the conversion PR keeps the original Java semicolons and double-quoted strings, under a
@SuppressWarnings('UnnecessarySemicolon')header and aTODO(groovyism-cleanup)comment, so git still recognizes each.java->.groovypair as a rename (see matrei's review on #16576). This PR removes that scaffolding and applies the Groovy idioms CodeNarc expects.Verification
CI note: this stacked branch inherits the temporary
CHANGEME FOR ACCEPTANCEworkflow-trigger commit from its base, so no CI runs on it. That commit must be reverted, and CI green, before this PR merges (blocker).🤖 Generated with Claude Code