Skip to content

docs: add java-to-groovy-conversion framework agent skill - #16785

Closed
borinquenkid wants to merge 1 commit into
10.0.xfrom
docs/skill-java-to-groovy-conversion-10.0.x
Closed

borinquenkid wants to merge 1 commit into
10.0.xfrom
docs/skill-java-to-groovy-conversion-10.0.x

Conversation

@borinquenkid

Copy link
Copy Markdown
Member

Adds the .agents/skills/java-to-groovy-conversion/SKILL.md framework development skill.

Summary

  • Documents the mandatory two-commit slice protocol (git mv in Commit 1 holding R100, idiomatic conversion in Commit 2).
  • Details the requirement for merge commits (--no-ff) so Git tracks file history under git log --follow.
  • Outlines verification tooling (javap -protected API diffs, javap -c -p bytecode sweeps, JavaCallerPin.java compile-time pins).
  • Provides the technical checklist for static compilation, Java-facing API preservation, Groovy semantics gotchas, and idiomatic style.
  • Registers the skill in AGENTS.md and .agents/skills/README.md.

Define the framework development skill for converting Java source files to
statically-compiled, idiomatic Groovy. Document the two-commit slice protocol,
merge commit requirement, verification sweeps (javap, JavaCallerPin), and
technical checklist for static compilation, Java-facing API preservation,
and Groovy semantics. Register the skill in AGENTS.md, CLAUDE.md, and the
skills README.
Copilot AI balanced review requested due to automatic review settings October 28, 2026 02:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.4919%. Comparing base (506b568) to head (226f9fb).
⚠️ Report is 915 commits behind head on 10.0.x.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               10.0.x     #16785        +/-   ##
==================================================
+ Coverage     63.7632%   64.4919%   +0.7286%     
- Complexity      28262      30194      +1932     
==================================================
  Files            2260       2372       +112     
  Lines          112201     116700      +4499     
  Branches        20361      21319       +958     
==================================================
+ Hits            71543      75262      +3719     
- Misses          31507      31803       +296     
- Partials         9151       9635       +484     

see 280 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@testlens-app

testlens-app Bot commented Oct 28, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 226f9fb
▶️ Tests: 136337 executed
⚪️ Checks: 91/91 completed


Learn more about TestLens at testlens.app/docs.

@jdaugherty

Copy link
Copy Markdown
Contributor

@borinquenkid it's incredibly hard to have so many pull requests open for groovy -> java conversion. I don't think this should be it's own pull request. We should do this work on the branch with the hibernate 7 conversion and focus on one module at a time. If these branches keep getting mass updated, it's so much noise that I'm inclined to reject them as it's a huge time sync to start reviews and then have to restart them because the branches are being constantly sync'd.

@borinquenkid

Copy link
Copy Markdown
Member Author

@jdaugherty Completely understood and agreed. The skill is already bundled directly into #16572 (in commit a3b6fa56d6), so closing this PR. We will focus strictly on #16572 and take it one module at a time without touching or syncing the other branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants