HIVE-29755: Standardize ASF license headers across Hive source Java files

[hemanthumashankar0511]

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

[okumin]

Can you remove the following files and ensure CI/CD passes?

• https://github.com/apache/hive/blob/master/checkstyle/asf.header.incremental
• https://github.com/apache/hive/blob/master/storage-api/checkstyle/asf.header.incremental
• https://github.com/apache/hive/blob/master/standalone-metastore/checkstyle/asf.header.incremental

I originally started the normalization with an incremental approach because no one can review a big rewrite. I'm happy to review and merge your change if you could.

[hemanthumashankar0511]

@okumin I've deleted the three files and the ci passes right now

[okumin]

@hemanthumashankar0511 Thank you! Would you mind if I asked you to apply the following changes.

diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml
index 306f8845a5..8448baa630 100644
--- a/checkstyle/checkstyle.xml
+++ b/checkstyle/checkstyle.xml
@@ -62,6 +62,7 @@
   <module name="Translation"/>
 
   <module name="Header">
+    <property name="severity" value="error"/>
     <property name="headerFile" value="${config_loc}/asf.header"/>
   </module>
 
diff --git a/standalone-metastore/checkstyle/checkstyle.xml b/standalone-metastore/checkstyle/checkstyle.xml
index f21bb3a068..0c5558a252 100644
--- a/standalone-metastore/checkstyle/checkstyle.xml
+++ b/standalone-metastore/checkstyle/checkstyle.xml
@@ -62,6 +62,7 @@
   <module name="Translation"/>
 
   <module name="Header">
+    <property name="severity" value="error"/>
     <property name="headerFile" value="${config_loc}/asf.header"/>
   </module>
 
diff --git a/storage-api/checkstyle/checkstyle.xml b/storage-api/checkstyle/checkstyle.xml
index a920085b9b..7fee2c5cf9 100644
--- a/storage-api/checkstyle/checkstyle.xml
+++ b/storage-api/checkstyle/checkstyle.xml
@@ -62,6 +62,7 @@
   <module name="Translation"/>
 
   <module name="Header">
+    <property name="severity" value="error"/>
     <property name="headerFile" value="${config_loc}/asf.header"/>
   </module>

and then to run mvn checkstyle:check? It will let you know the remaining violations.

[hemanthumashankar0511]

@hemanthumashankar0511 Thank you! Would you mind if I asked you to apply the following changes.

diff --git a/checkstyle/checkstyle.xml b/checkstyle/checkstyle.xml
index 306f8845a5..8448baa630 100644
--- a/checkstyle/checkstyle.xml
+++ b/checkstyle/checkstyle.xml
@@ -62,6 +62,7 @@
   <module name="Translation"/>
 
   <module name="Header">
+    <property name="severity" value="error"/>
     <property name="headerFile" value="${config_loc}/asf.header"/>
   </module>
 
diff --git a/standalone-metastore/checkstyle/checkstyle.xml b/standalone-metastore/checkstyle/checkstyle.xml
index f21bb3a068..0c5558a252 100644
--- a/standalone-metastore/checkstyle/checkstyle.xml
+++ b/standalone-metastore/checkstyle/checkstyle.xml
@@ -62,6 +62,7 @@
   <module name="Translation"/>
 
   <module name="Header">
+    <property name="severity" value="error"/>
     <property name="headerFile" value="${config_loc}/asf.header"/>
   </module>
 
diff --git a/storage-api/checkstyle/checkstyle.xml b/storage-api/checkstyle/checkstyle.xml
index a920085b9b..7fee2c5cf9 100644
--- a/storage-api/checkstyle/checkstyle.xml
+++ b/storage-api/checkstyle/checkstyle.xml
@@ -62,6 +62,7 @@
   <module name="Translation"/>
 
   <module name="Header">
+    <property name="severity" value="error"/>
     <property name="headerFile" value="${config_loc}/asf.header"/>
   </module>

and then to run mvn checkstyle:check? It will let you know the remaining violations.

@okumin One thing I noticed, the Header module seems to expect /* style
comments even for .properties files (e.g. log4j2.properties), which isn't
valid syntax for that file type. Should these be excluded via fileExtensions,
or is there a separate header format expected for non-Java files?

[okumin]

@hemanthumashankar0511
It likely means our current checkstyle.xml doesn't validate those files anyway. Therefore, I would add fileExtensions in this script, include java, and then create a follow-up ticket to address other extensions such as *.properties. It is incremental, and no degradation happens.
Thank you!

[Aggarwal-Raghav]

Better to choose the correctly formatted asf header present here https://www.apache.org/legal/src-headers.html#headers
BOTTOM part i.e. after http://www.apache.org/licenses/LICENSE-2.0 has line breaks after different words

ASF website header:

Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements.  See the NOTICE file
distributed with this work for additional information
regarding copyright ownership.  The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License.  You may obtain a copy of the License at

  http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied.  See the License for the
specific language governing permissions and limitations
under the License.    

[hemanthumashankar0511]

@Aggarwal-Raghav Thanks for pointing it out. I’ve updated the canonical asf.header to match the ASF website’s wrapped footer formatting and re-aligned the Java headers accordingly. Non-Java headers (e.g. .mvn/develocity.xml, poms, configs) will be handled in a follow-up JIRA.

[okumin]

+1. Please check the minor comment and accept the suggesion if I'm not wrong 👍

[hemanthumashankar0511]

Created follow up jira to address non java source files: HIVE-29812

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud