fix:update config during table refresh#3327
Merged
kevinjqliu merged 1 commit intoapache:mainfrom May 6, 2026
Merged
Conversation
gabeiglio
approved these changes
May 6, 2026
Contributor
gabeiglio
left a comment
There was a problem hiding this comment.
This is a good catch, we didn't see any issues before with access tokens as the fresh.config was being correctly propagated to the table's fileio
kevinjqliu
approved these changes
May 6, 2026
Contributor
There was a problem hiding this comment.
LGTM!
nice catch! now this matches the Table object's fields
iceberg-python/pyiceberg/table/__init__.py
Lines 1043 to 1053 in 6e68c9c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Table.refresh() was not updating self.config from the refreshed TableResponse. The config field contains out of date, server-generated properties such as per-table access tokens (token) and credential refresh endpoints(client.refresh-credentials-endpoint).
Are these changes tested?
Yes, with a new test.
Are there any user-facing changes?
No