add papermill-based notebook tests for pyiceberg examples#3330
Open
federicsp wants to merge 2 commits intoapache:mainfrom
Open
add papermill-based notebook tests for pyiceberg examples#3330federicsp wants to merge 2 commits intoapache:mainfrom
federicsp wants to merge 2 commits intoapache:mainfrom
Conversation
Author
|
@kevinjqliu the lint job failed on Python 3.14 with a uv cache error — looks unrelated to the PR. Could you take a look? |
Contributor
|
Ohhh, this is nice! Retriggered the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3328
Rationale for this change
pyiceberg_example.ipynbandspark_integration_example.ipynbhad noautomated test coverage. Breaking changes to notebook cells could go
undetected in CI.
This PR adds papermill-based tests that execute the
real notebooks as-is, so any change to a cell is automatically reflected
in the tests.
Are these changes tested?
Yes. The tests themselves are the change. Run them with:
Are there any user-facing changes?
No.