Skip to content

ci: add typecheck, docs and licence checks - #76

Merged
kparisa merged 3 commits into
apache:mainfrom
justinmclean:ci-checks
Sep 3, 2026
Merged

ci: add typecheck, docs and licence checks#76
kparisa merged 3 commits into
apache:mainfrom
justinmclean:ci-checks

Conversation

@justinmclean

Copy link
Copy Markdown
Member

Adds a checks job that runs alongside the existing build:

  • npm run typechecktsc --noEmit. There is no linter and no typecheck script today, so type errors only surface at the end of a full static export of every page.
  • npm run check:links — internal /docs links resolve, every page is listed in its meta.json, and every local asset referenced from content/ exists under public/.
  • npm run check:headers — ASF licence headers on source files under src/ and scripts/.
  • .asf.yaml parses as YAML. A typo there is silently ignored by infra today.

All four pass on main as of this branch, so they lock in the current state rather than fixing a broken one. Three files were missing licence headers and now have them: src/app/error.tsx, src/components/benchmark-chart.tsx, src/components/force-dark-theme.tsx.

Separately, this makes the GitHub star fetch non-destructive. It now sends GITHUB_TOKEN when one is available, since the anonymous API limit is per IP and shared runners hit it routinely; and when a fetch fails it keeps the previously fetched value instead of overwriting it with a hardcoded fallback that had drifted about 800 stars behind.

@kparisa
kparisa self-requested a review September 3, 2026 06:31
@kparisa
kparisa merged commit c1b4b80 into apache:main Sep 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants