Skip to content

feat(common)!: extensible key-value options for topics, streams, users - #3880

Open
numinnex wants to merge 11 commits into
masterfrom
rework_topic_commands
Open

feat(common)!: extensible key-value options for topics, streams, users#3880
numinnex wants to merge 11 commits into
masterfrom
rework_topic_commands

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 13, 2026
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.22785% with 424 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.51%. Comparing base (cbeb410) to head (edaf363).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
core/common/src/types/options/mod.rs 83.27% 67 Missing and 30 partials ⚠️
foreign/csharp/Iggy_SDK/Mappers/BinaryMapper.cs 36.73% 59 Missing and 3 partials ⚠️
...eign/csharp/Iggy_SDK/Contracts/Tcp/TcpContracts.cs 0.00% 40 Missing ⚠️
core/server/src/http/handlers.rs 50.68% 26 Missing and 10 partials ⚠️
...nary_serialization/binary_response_deserializer.go 57.57% 25 Missing and 3 partials ⚠️
core/cli/src/args/common.rs 0.00% 18 Missing ⚠️
core/common/src/wire_conversions.rs 80.64% 7 Missing and 11 partials ⚠️
core/server/src/responses.rs 86.15% 1 Missing and 17 partials ⚠️
core/binary_protocol/src/primitives/options.rs 93.63% 7 Missing and 7 partials ⚠️
core/server/src/bootstrap.rs 88.46% 7 Missing and 5 partials ⚠️
... and 29 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3880      +/-   ##
============================================
- Coverage     82.89%   80.51%   -2.38%     
- Complexity     1299     1308       +9     
============================================
  Files          1200     1205       +5     
  Lines        162348   164325    +1977     
  Branches     131823   133549    +1726     
============================================
- Hits         134571   132310    -2261     
- Misses        24238    28487    +4249     
+ Partials       3539     3528      -11     
Components Coverage Δ
Rust Core 83.46% <88.14%> (+0.05%) ⬆️
Java SDK 66.09% <ø> (+0.02%) ⬆️
C# SDK 37.39% <23.52%> (-38.59%) ⬇️
Python SDK 90.02% <ø> (+0.03%) ⬆️
PHP SDK 84.21% <ø> (-0.05%) ⬇️
Node SDK 96.01% <ø> (-0.20%) ⬇️
Go SDK 52.61% <57.57%> (-15.93%) ⬇️
Files with missing lines Coverage Δ
core/ai/mcp/src/service/requests.rs 100.00% <ø> (ø)
core/binary_protocol/src/codec.rs 80.64% <100.00%> (+0.38%) ⬆️
core/binary_protocol/src/codes.rs 100.00% <ø> (ø)
core/binary_protocol/src/dispatch.rs 92.94% <100.00%> (+0.05%) ⬆️
...ary_protocol/src/requests/streams/create_stream.rs 100.00% <100.00%> (ø)
...ary_protocol/src/requests/streams/update_stream.rs 100.00% <100.00%> (ø)
...y_protocol/src/requests/system/describe_options.rs 100.00% <100.00%> (ø)
...inary_protocol/src/requests/topics/create_topic.rs 100.00% <100.00%> (ø)
...inary_protocol/src/requests/topics/update_topic.rs 100.00% <100.00%> (ø)
.../binary_protocol/src/requests/users/create_user.rs 97.15% <100.00%> (+0.91%) ⬆️
... and 113 more

... and 147 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@numinnex
numinnex force-pushed the rework_topic_commands branch from 2c1c0bf to 6057a1e Compare August 14, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant