-
Notifications
You must be signed in to change notification settings - Fork 1.9k
IGNITE-27088 BinaryWriter should use internal String#value #13529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nizhikov
wants to merge
9
commits into
apache:master
Choose a base branch
from
nizhikov:IGNITE-27088
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2cea055
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov b6feacc
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov 9394099
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov cbb0052
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov d36ef1a
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov 55feffd
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov ccb6f14
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov 351fd2b
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov f7ce522
IGNITE-27088 BinaryWriter should use internal String#value
nizhikov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
163 changes: 163 additions & 0 deletions
163
.../java/org/apache/ignite/internal/benchmarks/jmh/binary/JmhBinaryStringWriteBenchmark.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.internal.benchmarks.jmh.binary; | ||
|
|
||
| import org.apache.ignite.internal.benchmarks.jmh.runner.JmhIdeBenchmarkRunner; | ||
| import org.apache.ignite.internal.binary.StringWriter; | ||
| import org.apache.ignite.internal.binary.streams.BinaryOutputStream; | ||
| import org.apache.ignite.internal.binary.streams.BinaryStreams; | ||
| import org.openjdk.jmh.annotations.Benchmark; | ||
| import org.openjdk.jmh.annotations.BenchmarkMode; | ||
| import org.openjdk.jmh.annotations.Measurement; | ||
| import org.openjdk.jmh.annotations.OutputTimeUnit; | ||
| import org.openjdk.jmh.annotations.Param; | ||
| import org.openjdk.jmh.annotations.Setup; | ||
| import org.openjdk.jmh.annotations.State; | ||
| import org.openjdk.jmh.annotations.TearDown; | ||
| import org.openjdk.jmh.annotations.Warmup; | ||
| import org.openjdk.jmh.infra.Blackhole; | ||
| import org.openjdk.jmh.profile.GCProfiler; | ||
| import org.openjdk.jmh.runner.Runner; | ||
| import org.openjdk.jmh.runner.options.OptionsBuilder; | ||
|
|
||
| import static java.util.concurrent.TimeUnit.NANOSECONDS; | ||
| import static java.util.concurrent.TimeUnit.SECONDS; | ||
| import static org.apache.ignite.IgniteCommonsSystemProperties.IGNITE_BINARY_STRING_ZERO_COPY; | ||
| import static org.openjdk.jmh.annotations.Mode.AverageTime; | ||
| import static org.openjdk.jmh.annotations.Scope.Thread; | ||
|
|
||
| /** | ||
| * Compares zero-copy string serialization with the legacy serialization. | ||
| * @see org.apache.ignite.IgniteCommonsSystemProperties#IGNITE_BINARY_STRING_ZERO_COPY | ||
| */ | ||
| @State(Thread) | ||
| @OutputTimeUnit(NANOSECONDS) | ||
| @BenchmarkMode(AverageTime) | ||
| @Warmup(iterations = 5, time = 5, timeUnit = SECONDS) | ||
| @Measurement(iterations = 5, time = 10, timeUnit = SECONDS) | ||
| public class JmhBinaryStringWriteBenchmark { | ||
| /** */ | ||
| @Param({"true", "false"}) | ||
| private boolean zeroCopy; | ||
|
|
||
| /** */ | ||
| @Param({"8", "64", "512", "4096"}) | ||
| private int len; | ||
|
|
||
| /** */ | ||
| @Param({"ascii", "latin1", "cyrillic", "mixed"}) | ||
| private String content; | ||
|
|
||
| /** */ | ||
| private BinaryOutputStream out; | ||
|
|
||
| /** */ | ||
| private String str; | ||
|
|
||
| /** */ | ||
| public static void main(String[] args) throws Exception { | ||
| OptionsBuilder builder = JmhIdeBenchmarkRunner.create() | ||
| .forks(1) | ||
| .benchmarks(JmhBinaryStringWriteBenchmark.class.getName()) | ||
| .profilers(GCProfiler.class) | ||
| .optionsBuilder(); | ||
|
|
||
| new Runner(builder.build()).run(); | ||
| } | ||
|
|
||
| /** */ | ||
| @Setup | ||
| public void setup() { | ||
| // Must be set before the first use of StringWriter in this JVM. | ||
| System.setProperty(IGNITE_BINARY_STRING_ZERO_COPY, String.valueOf(zeroCopy)); | ||
|
|
||
| StringBuilder sb = new StringBuilder(len); | ||
|
|
||
| for (int i = 0; sb.length() < len; i++) { | ||
| switch (content) { | ||
| case "ascii": | ||
| sb.append((char)('a' + i % 26)); | ||
|
|
||
| break; | ||
|
|
||
| case "latin1": | ||
| // Every 8th char is a Latin-1 char with the sign bit set. | ||
| sb.append(i % 8 == 7 ? (char)(0xC0 + i % 0x20) : (char)('a' + i % 26)); | ||
|
|
||
| break; | ||
|
|
||
| case "cyrillic": | ||
| sb.append((char)('\u0410' + i % 32)); | ||
|
|
||
| break; | ||
|
|
||
| case "mixed": | ||
| // ASCII, Latin-1, 2-byte, 3-byte chars and a surrogate pair. | ||
| switch (i % 5) { | ||
| case 0: | ||
| sb.append((char)('a' + i % 26)); | ||
|
|
||
| break; | ||
|
|
||
| case 1: | ||
| sb.append('\u00e9'); | ||
|
|
||
| break; | ||
|
|
||
| case 2: | ||
| sb.append('\u0416'); | ||
|
|
||
| break; | ||
|
|
||
| case 3: | ||
| sb.append('\u20ac'); | ||
|
|
||
| break; | ||
|
|
||
| default: | ||
| sb.append("\ud83d\ude00"); | ||
| } | ||
|
|
||
| break; | ||
|
|
||
| default: | ||
| throw new IllegalArgumentException("Unknown content type: " + content); | ||
| } | ||
| } | ||
|
|
||
| str = sb.toString(); | ||
|
|
||
| out = BinaryStreams.outputStream(4 * len + 64); | ||
| } | ||
|
|
||
| /** */ | ||
| @TearDown | ||
| public void tearDown() { | ||
| out.close(); | ||
| } | ||
|
|
||
| /** */ | ||
| @Benchmark | ||
| public void writeString(Blackhole bh) { | ||
| out.position(0); | ||
|
|
||
| StringWriter.write(str, out); | ||
|
|
||
| bh.consume(out.position()); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like false positive.
I run bench in ide and got results reflected in ticket.
Results clearly shows difference between two modes zeroCopy true/false.
Looks like setting fork=1 in setup method is enough.