Skip to content

IGNITE-29032 Improvement of the page eviction mechanism for in-memory - #13554

Open
wernerdv wants to merge 3 commits into
apache:masterfrom
wernerdv:IGNITE-29032
Open

IGNITE-29032 Improvement of the page eviction mechanism for in-memory#13554
wernerdv wants to merge 3 commits into
apache:masterfrom
wernerdv:IGNITE-29032

Conversation

@wernerdv

@wernerdv wernerdv commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@ignitetcbot

Copy link
Copy Markdown
Contributor

TCBot Test Analysis

Possible Blockers (0)

No blockers found.

New Tests (18)

  • Cache 21: 18 tests
    • IgniteCacheTestSuite19: Random2LruPageEvictionSizeAwareTest.testPutAllLargeRows - PASSED
    • IgniteCacheTestSuite19: Random2LruPageEvictionSizeAwareTest.testUpdateRowGrows - PASSED
    • IgniteCacheTestSuite19: Random2LruPageEvictionSizeAwareTest.testLargeObjectReadBack - PASSED
    • IgniteCacheTestSuite19: Random2LruPageEvictionSizeAwareTest.testPutLargeObjectsDoesNotOom - PASSED
    • IgniteCacheTestSuite19: RandomLruPageEvictionWithExpiryPolicyTest.testLargePutWithExpiryNoDeadlock - PASSED
    • IgniteCacheTestSuite19: RandomLruPageEvictionWithExpiryPolicyTest.testTtlFreedSpaceAccountedForByEviction - PASSED
    • IgniteCacheTestSuite19: Random2LruPageEvictionWithExpiryPolicyTest.testLargePutWithExpiryNoDeadlock - PASSED
    • IgniteCacheTestSuite19: Random2LruPageEvictionWithExpiryPolicyTest.testTtlFreedSpaceAccountedForByEviction - PASSED
    • IgniteCacheTestSuite19: RandomLruPageEvictionSizeAwareTest.testUpdateRowGrows - PASSED
    • IgniteCacheTestSuite19: RandomLruPageEvictionSizeAwareTest.testRecordLargerThanRegionOom - PASSED
    • ... and 8 more new tests

@wernerdv wernerdv changed the title IGNITE-29032 Improvement of the pageEviction mechanism for in-memory IGNITE-29032 Improvement of the page eviction mechanism for in-memory Sep 5, 2026
@wernerdv
wernerdv requested a balanced review from Copilot September 5, 2026 16:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Improves in-memory page eviction to support large rows and avoid lock-ordering deadlocks.

Changes:

  • Adds size-aware eviction for single and batch inserts.
  • Introduces non-blocking eviction locking and progress guards.
  • Expands eviction regression tests for both LRU modes.
File summaries
File Description
modules/core/src/test/java/org/apache/ignite/testsuites/IgniteCacheEvictionSelfTestSuite.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/RandomLruPageEvictionWithExpiryPolicyTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/RandomLruPageEvictionSizeAwareTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/RandomLruPageEvictionConcurrentWritesTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/Random2LruPageEvictionWithExpiryPolicyTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/Random2LruPageEvictionSizeAwareTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/Random2LruPageEvictionConcurrentWritesTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionWithExpiryPolicyAbstractTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionSizeAwareAbstractTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionPutLargeObjectsAbstractTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionMetricTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionGuardOomTest.java Updated as part of this pull request.
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/eviction/paged/PageEvictionConcurrentWritesAbstractTest.java Updated as part of this pull request.
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/RowStore.java Updated as part of this pull request.
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/IgniteCacheDatabaseSharedManager.java Updated as part of this pull request.
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/evict/PageAbstractEvictionTracker.java Updated as part of this pull request.
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java Updated as part of this pull request.
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryEx.java Updated as part of this pull request.
modules/core/src/main/java/org/apache/ignite/configuration/DataRegionConfiguration.java Updated as part of this pull request.
Review details
  • Files reviewed: 19/19 changed files
  • Comments generated: 11
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants