Allow Rootly plugin to collect incidents without service identifiers assigned#8892
Merged
Merged
Conversation
The mapStatus function was missing 'completed' as a terminal status, causing incidents with that status to be written as IN_PROGRESS instead of DONE. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rootly's 'completed' status represents a fully resolved incident that has gone through post-incident review. These incidents may not have a resolved_date populated. Fall back to updated_date so MTTR is computed correctly instead of showing the incident as unresolved. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Allow collecting all incidents without filtering by service ID. Previously, all incidents required a service association to be collected; incidents created without service tags (common in Rootly) were silently dropped. Changes: - ValidateTaskOptions: service_id is now optional (no longer required) - GetParams: falls back to scope_id 'all' when service_id is empty - buildIncidentsQuery: only adds filter[service_ids] when service_id is set - extractRootlyIncident: skips the service-membership guard when collecting globally (service_id = '') to avoid false drops Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dosubot
Bot
added
size:M
klesh
approved these changes
May 30, 2026
Contributor
klesh
left a comment
klesh
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
Allows the Rootly plugin to collect incidents missing service identifiers
Does this close any open issues?
Closes 8891