Add autoscroll, autoscroll stop on 1st failed, preferred width and goto selected sampler name in ViewResultsTree listener#6245
Open
KingRabbid wants to merge 5 commits intoapache:masterfrom
Open
Conversation
FSchumacher
reviewed
Sep 27, 2024
Contributor
FSchumacher
left a comment
FSchumacher
left a comment
There was a problem hiding this comment.
Apart from the comment, it looks good to me.
| .append(JMeterUtils | ||
| .getResString("view_results_thread_name")) //$NON-NLS-1$ | ||
| .append(sampleResult.getThreadName()).append(NL); | ||
| statsBuff |
Contributor
There was a problem hiding this comment.
This should be mentioned in the title of this PR. Was this intended to be included?
Contributor
Author
There was a problem hiding this comment.
Ah, yes, this was an later add-on. Purpose is: dealing with a long samplers listing in a View Results Tree one can easily lose relation between scroll on left side and selected sampler on right side.
Having the sampler name included can help in tracking between the 2 sources of information.
I will update PR title.
Contributor
Author
There was a problem hiding this comment.
More changes included
KingRabbid
changed the title
… checkbox to stop autoscroll on error; add button to focus listing on selected node.
KingRabbid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add 2 configurable parameters to allow enabling by default the scroll tick in the ViewResultsTree box and also to set the width of the tree to desired value. Parameters are defined in jmeter.properties file.
Motivation and Context
I have to load & run many JMXs per day and every time I have to adjust the tick and the width to a personal preference, it's annoying. Also with various resolutions the width makes sense to have different values than the standard one.
How Has This Been Tested?
Run with multiple values in the .properties file, see the outcome.
Screenshots (if appropriate):
Types of changes
Checklist: