Skip to content

Remove deprecated Cookie calls in ProxyServlet - #2851

Open
holgerfriedrich wants to merge 1 commit into
apache:mainfrom
holgerfriedrich:pr-httpcookie-deprecations
Open

Remove deprecated Cookie calls in ProxyServlet#2851
holgerfriedrich wants to merge 1 commit into
apache:mainfrom
holgerfriedrich:pr-httpcookie-deprecations

Conversation

@holgerfriedrich

@holgerfriedrich holgerfriedrich commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Cookie.setComment(String) and Cookie.setVersion(int) are deprecated for removal in Jakarta Servlet 6.1 and specified as no-ops: setComment is ignored and getComment() returns null, setVersion is ignored and getVersion() returns 0.

See documentation
https://jakarta.ee/specifications/servlet/6.1/apidocs/jakarta.servlet/jakarta/servlet/http/cookie

With the adoption of support for RFC 6265, this method should no longer be used.

If called, this method has no effect.

Cookie.setComment(String) and Cookie.setVersion(int) are deprecated for
removal in Jakarta Servlet 6.1 and specified as no-ops: setComment is
ignored and getComment() returns null, setVersion is ignored and
getVersion() returns 0.
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

Test Results

  702 files  ±0    702 suites  ±0   1h 17m 0s ⏱️ -28s
  932 tests ±0    884 ✅ ±0   48 💤 ±0  0 ❌ ±0 
2 796 runs  ±0  2 652 ✅ ±0  144 💤 ±0  0 ❌ ±0 

Results for commit 8aaa13c. ± Comparison against base commit ed4d306.

@jbonofre
jbonofre self-requested a review September 6, 2026 16:22
@jbonofre

jbonofre commented Sep 6, 2026

Copy link
Copy Markdown
Member

As original author of the ProxyServlet (😄 ) I will review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants