Implement node status synchronization in Controller, including downtime notifications and online/offline management#388
Merged
git-hulk merged 4 commits intoapache:unstablefrom Apr 24, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #388 +/- ##
============================================
+ Coverage 43.38% 50.17% +6.79%
============================================
Files 37 45 +8
Lines 2971 3906 +935
============================================
+ Hits 1289 1960 +671
- Misses 1544 1732 +188
- Partials 138 214 +76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
git-hulk
reviewed
Apr 20, 2026
Member
|
@Paragrf Sorry for the late review due to the heavy traffic at work. |
Paragrf
force-pushed
the
ha
branch
2 times, most recently
from
dc2de98 to
87937e4
Compare
Contributor
Author
|
@git-hulk Internal interfaces now support more node states, but external online/offline APIs remain backward compatible with original semantics. |
git-hulk
reviewed
Apr 23, 2026
git-hulk
reviewed
Apr 23, 2026
Contributor
Author
|
Added a configuration option where HA does not modify the status of failed slave nodes by default, ensuring backward compatibility with legacy Kvrocks. |
git-hulk
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
To improve cluster reliability and operational efficiency, the controller needs to bridge the status gap between slave nodes and the server. Beyond just reporting unexpected failures, it is essential to support proactive maintenance workflows, allowing operators to safely remove traffic before performing node updates or hardware swaps.
Key Changes
Downtime Push: The controller now monitors slave node health and proactively pushes "Downtime" alerts to the server upon detection of a crash or heartbeat timeout.
Manual Offline (Traffic Draining): Supports a proactive "Offline" command. This allows the server to drain/stop traffic to a specific slave node before any maintenance work begins, ensuring zero-impact operations.
Manual Online: Supports a "Ready-to-Serve" notification when a slave is back online and fully synchronized, allowing the server to safely re-enable traffic.
Related Issues
Fixes #385