Skip to content

Extend plugin processor message filtering and add [Log4j] prefixes - #4228

Merged
vy merged 2 commits into
apache:2.xfrom
DragonFSKY:fix-4225-plugin-processor-messages
Aug 14, 2026
Merged

Extend plugin processor message filtering and add [Log4j] prefixes#4228
vy merged 2 commits into
apache:2.xfrom
DragonFSKY:fix-4225-plugin-processor-messages

Conversation

@DragonFSKY

Copy link
Copy Markdown
Contributor

Fixes #4225.

This change:

  • makes GraalVmProcessor respect the existing log4j.plugin.processor.minAllowedMessageKind annotation processor option;
  • prefixes diagnostics emitted by PluginProcessor and GraalVmProcessor with [Log4j];
  • preserves the default NOTE threshold and the existing severity filtering semantics;
  • keeps plugin descriptor and GraalVM metadata generation independent from diagnostic filtering;
  • updates the processor tests, plugin manual, and changelog.

The diagnostic prefix is an intentional text change. No generated file format or public API is changed.

Verification

  • ./mvnw -pl log4j-core-test -am -Dtest=GraalVmProcessorTest,PluginProcessorPublicSetterTest -Dsurefire.failIfNoSpecifiedTests=false test (21 tests)
  • ./mvnw -pl log4j-core,log4j-core-test spotless:check
  • ./mvnw verify (41 reactor modules)
  • git diff --check

Checklist

  • Changes are based on the 2.x branch.
  • The Maven verification succeeds.
  • A changelog entry is included under src/changelog/.2.x.x.
  • Tests are provided.

@vy vy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread src/site/antora/modules/ROOT/pages/manual/plugins.adoc Outdated
Comment thread src/changelog/.2.x.x/4225_plugin_processor_messages.xml
@github-project-automation github-project-automation Bot moved this to Changes requested in Log4j pull request tracker Aug 14, 2026
Co-authored-by: Volkan Yazıcı <volkan.yazici@oracle.com>
@github-project-automation github-project-automation Bot moved this from Changes requested to Approved in Log4j pull request tracker Aug 14, 2026
@vy
vy enabled auto-merge (squash) August 14, 2026 08:34
@vy
vy merged commit bf873ae into apache:2.x Aug 14, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Log4j pull request tracker Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Consider making plugin builds less chatty

2 participants