fix(runtime): filter broken models from OpenCode Free probe candidates - #5185
Open
SummerC0zyR0ck wants to merge 1 commit into
Open
fix(runtime): filter broken models from OpenCode Free probe candidates#5185SummerC0zyR0ck wants to merge 1 commit into
SummerC0zyR0ck wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3449
OpenCode Free connection tests could still probe a quarantined model saved in
enabledModelIdsordefaultModel, even though the model catalog and execution authorization already rejected the samebrokenModelIdsentry.This change makes the connection-test candidate path use the same quarantine authority as the catalog and execution paths:
No model to testresult when every candidate is quarantined;provenance behavior.
Verification
Focused Runtime regression coverage passed: 10 tests, 0 failures. The affected OpenCode Free connection-test suite verifies:
enabledModelIdsare excluded from probing;defaultModeldoes not block selection of a healthy fallback;No model to test;Authorizationheader;content: nullremain valid;Build and static checks also passed:
The full repository test suite was not run.
AI use
Tool(s) and scope: OpenAI Codex investigated the defect and fixed, authored the implementation review and Runtime/UI/TUI regression tests.
Checklist
Does this PR entail a change in behavior?
registry; explicit model testing and manual model switching are unchanged.