Skip to content

Keep the recompiling message at the INFO level when user explicitly requested that information #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
desruisseaux merged 1 commit into from
Aug 7, 2026
+7 −2
Merged

Keep the recompiling message at the INFO level when user explicitly requested that information #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/maven/plugin/compiler/IncrementalBuild.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ static EnumSet<Aspect> parse(final String values) {
/**
* Whether to provide more details about why a module is rebuilt.
*/
private final boolean showCompilationChanges;
final boolean showCompilationChanges;

@elharo elharo Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the user set this? Is there a paremter somewhere?

@desruisseaux desruisseaux Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a parameter in CompilerMojo. This parameter already existed in the Maven 3 plugin.


/**
* Creates a new helper for an incremental build.
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,12 @@
if (n > 1) {
sb.append('s'); // Make plural.
}
logger.info(sb.append('.'));
sb.append('.');
if (incrementalBuild.showCompilationChanges) {
logger.info(sb);
} else {
logger.debug(sb);
}
}
}
if (!(checkSources | checkDepends | checkOptions)) {
Expand Down Expand Up @@ -617,7 +622,7 @@
if (moduleNameFromPackageHierarchy == null) {
detected = DirectoryHierarchy.PACKAGE;
} else {
detected = DirectoryHierarchy.PACKAGE_WITH_MODULE;

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-17-zulu 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-zulu 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-temurin 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-temurin 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-25-zulu 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-microsoft 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / macos-latest jdk-21-adopt-openj9 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-temurin 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-zulu 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-temurin 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-25-zulu 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-microsoft 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated

Check warning on line 625 in src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java

View workflow job for this annotation

GitHub Actions / Verify / ubuntu-latest jdk-21-adopt-openj9 4.0.0-rc-6 

PACKAGE_WITH_MODULE in org.apache.maven.plugin.compiler.DirectoryHierarchy has been deprecated
}
} else {
if (moduleNameFromPackageHierarchy == null) {
Expand Down
Loading