Fix #141: read all lines of version text files - #158
Open
elharo wants to merge 2 commits into
Open
Conversation
TextFileExposer only read the first line of a version text file, losing all data beyond line 1 (e.g. key=value pairs, multi-line version headers). Read all non-empty lines in a loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #141
Problem
TextFileExposeronly read the first line of a version text file:Version files with multi-line content (e.g.
key=valuepairs, multi-line version headers) lose all data beyond line 1.Fix
Read all lines in a loop:
Test
Added
TextFileExposerTestwith two tests that build jars containing multi-line version files and assert all lines are exposed. Both fail on the old code (only first line returned) and pass with the fix.