MINIFICPP-2797 Extend C Api with sslcontext, penalize, dynamic properties, flowfile id and size#2166
Closed
martinzink wants to merge 7 commits into
Closed
MINIFICPP-2797 Extend C Api with sslcontext, penalize, dynamic properties, flowfile id and size#2166martinzink wants to merge 7 commits into
martinzink wants to merge 7 commits into
Conversation
martinzink
force-pushed
the
MINIFICPP-2797
branch
from
67568b6 to
61f301a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the MiNiFi C extension API to expose additional ProcessSession/ProcessContext capabilities needed by external extensions (e.g., Kafka migration), including penalization, FlowFile metadata access, dynamic properties enumeration, and SSLContextService data access.
Changes:
- Adds new exported C API functions (penalize, flowfile id/size, dynamic properties, SSL data) and renames FlowFile attribute functions under
MinifiProcessSession*. - Implements the new API surface in
libminifi/src/minifi-c.cpp. - Updates the C++ extension wrapper (
cpp-extension-lib) to call the renamed attribute APIs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| minifi-api/minifi-c-api.def | Updates Windows export list with new/renamed C API symbols. |
| minifi-api/include/minifi-c/minifi-c.h | Adds new C API declarations/constants and SSL data struct/callback. |
| libminifi/src/minifi-c.cpp | Implements new C API functions for penalize, flowfile metadata, dynamic properties, and SSL data. |
| extension-framework/cpp-extension-lib/src/core/ProcessSession.cpp | Migrates wrapper to renamed attribute APIs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martinzink
force-pushed
the
MINIFICPP-2797
branch
from
61f301a to
430e4c1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
szaszm
reviewed
May 4, 2026
adamdebreceni
approved these changes
May 5, 2026
martinzink
added a commit
that referenced
this pull request
May 5, 2026
…ties, flowfile id and size #2166
This was referenced May 5, 2026
szaszm
reviewed
May 6, 2026
szaszm
reviewed
May 6, 2026
martinzink
force-pushed
the
MINIFICPP-2797
branch
from
f6912bf to
95ddfef
Compare
szaszm
reviewed
May 12, 2026
Co-authored-by: Márton Szász <szaszm@apache.org>
szaszm
approved these changes
May 12, 2026
fgerlits
approved these changes
May 12, 2026
lordgamez
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MINIFICPP-2797
There are a couple functions missing from the stable API that prevents us to migrate Kafka,
namely penalize, sslcontext functionality, dynamic property handling, flowfile id and flowfile size
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.