NIFI-16026 - Add Hex format for kafka messages in ConsumeKafka#11356
Open
awelless wants to merge 1 commit into
Open
NIFI-16026 - Add Hex format for kafka messages in ConsumeKafka#11356awelless wants to merge 1 commit into
awelless wants to merge 1 commit into
Conversation
Add a 'Header Format' property (String/Hex) to ConsumeKafka so binary Kafka Record Header values can be written as a lowercase hexadecimal string instead of being corrupted by charset decoding. The existing 'Header Encoding' property keeps its meaning (the character set used for the String format) and is shown only when Header Format is String, so existing flows are unchanged and no property migration is needed. Header decoding is resolved once into a HeaderValueConverter in onScheduled and applied uniformly to FlowFile attributes and the wrapper/inject-metadata record header fields. Internal batch headers (kafka.max.offset, kafka.count) decode as fixed UTF-8, matching how they are written. Also add unit tests for KafkaUtils.toKeyString and correct the KeyEncoding HEX description, which claimed uppercase output although HexFormat.of() emits lowercase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16026
Add a 'Header Format' property (String/Hex) to ConsumeKafka so binary Kafka Record Header values can be written as a lowercase hexadecimal string instead of being corrupted by charset decoding. The existing 'Header Encoding' property keeps its meaning (the character set used for the String format) and is shown only when Header Format is String. Existing flows are unchanged and no property migration is needed.
Header decoding is resolved once into a
HeaderValueConverterinonScheduledand applied uniformly to FlowFile attributes and the wrapper/inject-metadata record header fields. Internal batch headers (kafka.max.offset,kafka.count) decode as fixed UTF-8, matching how they are written.Also add unit tests for
KafkaUtils.toKeyStringand correct the KeyEncoding HEX description, which claimed uppercase output although HexFormat.of() emits lowercase.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation