Skip to content

feat(services/sftp): port from openssh to russh #7977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chitralverma wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(services/sftp): port from openssh to russh #7977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60818a0
feat(services/sftp): port from openssh to russh
chitralverma Jul 28, 2026
34331a3
build(bindings): enable sftp on windows
chitralverma Jul 28, 2026
75b4a68
fix(services/sftp): close remote handles and harden edge cases
chitralverma Jul 28, 2026
5f4c5cc
fix(services/sftp): gate agent identity cap to unix
chitralverma Jul 28, 2026
d0bd1b0
fix(services/sftp): emit the listed directory from its handle
chitralverma Jul 28, 2026
7901942
fix(services/sftp): drop trailing separators from remote paths
chitralverma Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/dotnet/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ opendal = { version = ">=0", path = "../../core", features = [
"services-redis",
# FIXME: rocksdb will lead to "cannot allocate memory in static TLS block" while linking.
# "services-rocksdb",
"services-sftp",
"services-sled",
"services-tikv",
"services-vercel-artifacts",
Expand All @@ -110,6 +111,5 @@ tokio = { version = "1.49.0", features = ["full"] }
features = [
# Depend on unix-only dependency stacks in current implementations.
"services-monoiofs",
"services-sftp",
]
path = "../../core"
10 changes: 1 addition & 9 deletions bindings/java/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ opendal = { version = ">=0", path = "../../core", default-features = false, feat
"services-redis",
# FIXME: rocksdb will lead to "cannot allocate memory in static TLS block" while linking.
# "services-rocksdb",
"services-sftp",
"services-sled",
"services-tikv",
"services-vercel-artifacts",
Expand All @@ -103,12 +104,3 @@ opendal = { version = ">=0", path = "../../core", default-features = false, feat
"services-yandex-disk",
] }
tokio = { version = "1.49.0", features = ["full"] }

# This is not optimal. See also the Cargo issue:
# https://github.com/rust-lang/cargo/issues/1197#issuecomment-1641086954
[target.'cfg(unix)'.dependencies.opendal]
features = [
# Depend on "openssh" which depends on "tokio-pipe" that is unavailable on Windows.
"services-sftp",
]
path = "../../core"
5 changes: 1 addition & 4 deletions bindings/python/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ services-all = [
'services-redb',
'services-redis',
'services-seafile',
'services-sftp',
'services-sled',
'services-sqlite',
'services-swift',
Expand Down Expand Up @@ -187,10 +188,6 @@ services-yandex-disk = ["opendal/services-yandex-disk"]
# we build cp311-abi3 and cp310 wheels now, move this to pyo3 after we drop cp310
abi3 = ["pyo3/abi3-py311"]

# Conditionally include sftp only on non-windows targets
[target.'cfg(not(windows))'.features]
services-all = ["services-sftp"]

[lib]
crate-type = ["cdylib"]
doc = false
Expand Down
Loading
Loading