feat(core)!: compio executor - #8038
Conversation
c23d35f to
3618dcc
Compare
7510e51 to
7d59887
Compare
Xuanwo
left a comment
There was a problem hiding this comment.
Nice changeset! So happy to see it really happens!
The only thing we need to discuss is the merge process. I think @erickguan is working on a new patch release, we can merge once the new patch has been released.
| all-features = true | ||
|
|
||
| [features] | ||
| default = ["executors-tokio"] |
There was a problem hiding this comment.
This will be a breaking change. We need to hold on this PR until our next minor release.
|
One more question, does compio executor work along with |
no. we'd have to add a new transport layer with |
The master branch seems to have a CI failure. Once that is fixed, I'll release 0.58.2. And we can merge this PR too. |
If so, can we have an end-to-end working demo first? Then we can think about how to merge it into OpenDAL. Maybe in a stack PR way? |
sure thing |
Which issue does this PR close?
Closes #8037.
Rationale for this change
It's good to have another option for user to choose, even if it's not a popular one. I personally would really want to use OpenDAL on compio.
What changes are included in this PR?
This PR brings two major changes:
Execute's timeout function so that timeout layer can useExecute::timeoutdirectly.CompioExecutor.Are there any user-facing changes?
Executetrait is changed. Though I believecoreis considered a hidden API that user should not use directly. Not very sure if this consititutes a breaking change.AI Usage Statement
I used codex's gpt-5.6-sol to brainstorm & implement part of the PR. I have thoroughly reviewed the change and fixed any issue I found before submitting this PR.