Skip to content

feat(core)!: compio executor - #8038

Open
George-Miao wants to merge 1 commit into
apache:mainfrom
George-Miao:main
Open

feat(core)!: compio executor#8038
George-Miao wants to merge 1 commit into
apache:mainfrom
George-Miao:main

Conversation

@George-Miao

@George-Miao George-Miao commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #8037.

Rationale for this change

It's good to have another option for user to choose, even if it's not a popular one. I personally would really want to use OpenDAL on compio.

What changes are included in this PR?

This PR brings two major changes:

  • Refactored Execute's timeout function so that timeout layer can use Execute::timeout directly.
  • Implement CompioExecutor.

Are there any user-facing changes?

Execute trait is changed. Though I believe core is considered a hidden API that user should not use directly. Not very sure if this consititutes a breaking change.

AI Usage Statement

I used codex's gpt-5.6-sol to brainstorm & implement part of the PR. I have thoroughly reviewed the change and fixed any issue I found before submitting this PR.

@George-Miao
George-Miao requested a review from Xuanwo as a code owner August 7, 2026 17:10
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Aug 7, 2026
@George-Miao
George-Miao force-pushed the main branch 2 times, most recently from c23d35f to 3618dcc Compare August 7, 2026 17:47
@George-Miao
George-Miao requested a review from PsiACE as a code owner August 7, 2026 17:47
Comment thread core/Cargo.toml Outdated
@George-Miao
George-Miao requested a review from tisonkun as a code owner August 8, 2026 06:18
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 8, 2026
@George-Miao
George-Miao force-pushed the main branch 4 times, most recently from 7510e51 to 7d59887 Compare August 8, 2026 07:45

@Xuanwo Xuanwo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changeset! So happy to see it really happens!

The only thing we need to discuss is the merge process. I think @erickguan is working on a new patch release, we can merge once the new patch has been released.

Comment thread core/core/Cargo.toml
all-features = true

[features]
default = ["executors-tokio"]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a breaking change. We need to hold on this PR until our next minor release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@Xuanwo

Xuanwo commented Aug 8, 2026

Copy link
Copy Markdown
Member

One more question, does compio executor work along with http-transport-reqwest?

@George-Miao

Copy link
Copy Markdown
Contributor Author

One more question, does compio executor work along with http-transport-reqwest?

no. we'd have to add a new transport layer with cyper which is built on hyper and compio's tcp and tls layer.

@George-Miao George-Miao changed the title feat(core): compio executor feat(core)!: compio executor Aug 8, 2026
@erickguan

Copy link
Copy Markdown
Member

The only thing we need to discuss is the merge process. I think @erickguan is working on a new patch release, we can merge once the new patch has been released.

The master branch seems to have a CI failure. Once that is fixed, I'll release 0.58.2. And we can merge this PR too.

@Xuanwo

Xuanwo commented Aug 9, 2026

Copy link
Copy Markdown
Member

no. we'd have to add a new transport layer with cyper which is built on hyper and compio's tcp and tls layer.

If so, can we have an end-to-end working demo first? Then we can think about how to merge it into OpenDAL. Maybe in a stack PR way?

@George-Miao

Copy link
Copy Markdown
Contributor Author

no. we'd have to add a new transport layer with cyper which is built on hyper and compio's tcp and tls layer.

If so, can we have an end-to-end working demo first? Then we can think about how to merge it into OpenDAL. Maybe in a stack PR way?

sure thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new feature: compio executor support

3 participants