fix(services/oss): honor if_not_exists on multipart uploads - #8041
Merged
Conversation
OSS requires x-oss-forbid-overwrite on both InitiateMultipartUpload and CompleteMultipartUpload. Also skip the chunked-writer GCS coverage that the XML multipart API cannot satisfy, tracked in #8040.
dosubot
Bot
added
size:M
PsiACE
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #8040.
Rationale for this change
#8028 added behavior coverage for chunked writers with
if_not_exists. That exposed two gaps on main:write_with_if_not_exists, but multipart initiate/complete did not sendx-oss-forbid-overwrite, sowriter_with(...).if_not_exists(true)overwrote existing objects.What changes are included in this PR?
x-oss-forbid-overwrite: trueon bothInitiateMultipartUploadandCompleteMultipartUploadwhenif_not_existsis set.test_writer_write_with_if_not_existsfor GCS and point to services/gcs: XML multipart writer cannot honor write_with_if_not_exists #8040.Are there any user-facing changes?
Yes. OSS multipart writers now honor
if_not_existsinstead of silently overwriting. No public API signature changes.AI Usage Statement
Assisted by Cursor.